Add a check point to avoid null exception #150
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…, so add a null check to avoid. In dev stage, maybe has some empty implement.
liubao68
reviewed
Sep 20, 2017
| paramName = correctMethodParameterName(paramName); | ||
|
|
||
| JavaType paramJavaType = ConverterMgr.findJavaType(classLoader, | ||
| if (swagger.getPaths() != null) { |
There was a problem hiding this comment.
当一个接口没有定义任何方法的时候，会出现swagger.getPaths为空？这种情况也该是不合理的接口定义吧。是否打印一个日志警告。
There was a problem hiding this comment.
空实现的时候就会出现空指针异常，开发过程有时会同时复制多个，暂时没有实现的模块，启动就会有问题，后面都会有具体实现，只影响开发阶段，日志警告意义不大。
There was a problem hiding this comment.
这种情况还是不要留着吧。开发的时候一些可能的垃圾代码，还去容错不是好的实践。 这里能够构造出一个测试用例来的话还可以考虑下。
There was a problem hiding this comment.
日志能够帮助用户快速定位问题， 建议还是把错误日志加上吧！
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If a Rest class has no method, it will declared a nullpoint exception, so add a null check to avoid. In dev stage, maybe has some empty implement.