JAV-349 Unify http request #152
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 7 commits
September 19, 2017 09:32
wujimin
force-pushed
the
unify-http-request
branch
from
46088bf to
10e7028
Compare
wujimin
force-pushed
the
unify-http-request
branch
from
10e7028 to
6523574
Compare
added 6 commits
September 19, 2017 14:23
|
@wujimin Could you take a look the code coverage report? It looks like there are some lines are not covered. |
added 9 commits
September 19, 2017 22:27
… from client request
… now, forbid to run signature demo when use vertx rest transport temporary
wujimin
force-pushed
the
unify-http-request
branch
from
6523574 to
142c718
Compare
|
yes, i added so many test case in this PR, but coverage decreased...... |
wujimin
force-pushed
the
unify-http-request
branch
from
df647ac to
9840278
Compare
|
simpler some implements, and delete many useless class in new implements, maybe this cause the coverage decreased |
liubao68
reviewed
Sep 20, 2017
| if (serverSignature != null && !signature.equals(serverSignature)) { | ||
| return Response.create(Status.UNAUTHORIZED, "signature failed"); | ||
| if (serverSignature != null) { | ||
| LOGGER.info("check response signature, client: {}, server: {}.", signature, serverSignature); |
There was a problem hiding this comment.
sinature不要记录到日志里面。 属于敏感信息内容
There was a problem hiding this comment.
just demo, not product
liubao68
reviewed
Sep 20, 2017
| try { | ||
| String signature = SignatureUtils.genSignature(request.getRequestURI(), invocation.getContext(), request); | ||
| String clientSignature = invocation.getContext("signature"); | ||
| LOGGER.info("check request signature, client: {}, server: {}.", clientSignature, signature); |
There was a problem hiding this comment.
sinature不要记录到日志里面。 属于敏感信息内容
There was a problem hiding this comment.
just demo, not product
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
unify http request to standard HttpServletRequest, not private interface