JAV-355 Extract rest invocation #161
Conversation
| for (HttpServerFilter filter : httpServerFilters) { | ||
| Response response = filter.afterReceiveRequest(invocation, requestEx); | ||
| if (response != null) { | ||
| sendResponseQuietly(response); |
There was a problem hiding this comment.
it looks like the filter could hijack the response message which calling the doInvoke method.
I don't think it's good idea, there are too much assumption.
There was a problem hiding this comment.
if user decided to break the filter chain, and direct send response, user return a Response.
if do not do like this, we need to build another mechanism like handler chain or some api to send response, it's too complex.
what's your suggestion?
There was a problem hiding this comment.
Please add some comments in the HttpServerFilter.afterReceiveRequst, to make sure user know about this kind of feature.
We still need to make sure the doInvoke() is called in the invoke method, no matter what kind of HttpServerFilter is used.
There was a problem hiding this comment.
already have comments in HttpServerFilter.afterReceiveRequst and HttpClientFilter.afterReceiveResponse in current PR code.
| import io.servicecomb.swagger.invocation.Response; | ||
| import io.servicecomb.swagger.invocation.exception.InvocationException; | ||
|
|
||
| public class AbstractRestServer { |
There was a problem hiding this comment.
Is it safe to remove the AbstractRestServer?
There was a problem hiding this comment.
this is our internal class, not a interface to developers
4 participants
No description provided.