JAV-408 Event manager added for chassis events #163
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
WillemJiang
requested changes
Sep 26, 2017
There was a problem hiding this comment.
@acsukesh Can you reformat the code with the format file with the code format in the https://github.com/ServiceComb/ServiceComb-Java-Chassis/tree/master/etc ?
wujimin
reviewed
Sep 27, 2017
|
|
||
| import com.google.common.eventbus.EventBus; | ||
|
|
||
| public class TestEventManager { |
There was a problem hiding this comment.
this is test for eventBus, not for EventManager
and just call some method, did not verify result.
wujimin
reviewed
Sep 27, 2017
| LOGGER.error("Disconnected from service center and heartbeat failed for microservice instance={}/{}", | ||
| microserviceInstance.getServiceId(), | ||
| microserviceInstance.getInstanceId()); | ||
| EventManager.post(new HeartbeatFailEvent()); |
There was a problem hiding this comment.
what's the relationship between EventManager and EventBus in ServiceRegistry?
|
@WillemJiang & @wujimin all comments handled , please review and merge the code |
wujimin
approved these changes
Sep 28, 2017
WillemJiang
approved these changes
Sep 28, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
added event manager to subscribe and publish events in java chassis