Skip to content

Conversation

eric-lee-ltk
Copy link
Contributor

Signed-off-by: eric-lee-ltk lidagang1@huawei.com

Signed-off-by: eric-lee-ltk <lidagang1@huawei.com>
@coveralls
Copy link

Coverage Status

Coverage decreased (-0.06%) to 86.616% when pulling 83ff9dd on eric-lee-ltk:optimize into 0b32070 on ServiceComb:master.

Copy link
Contributor

@liubao68 liubao68 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add test cases of JAV-411

import io.servicecomb.core.Invocation;
import io.servicecomb.core.definition.OperationMeta;
import io.servicecomb.foundation.ssl.SSLCustom;
import io.servicecomb.foundation.ssl.SSLOption;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add test cases of JAV-411 and I'll discard changes of JAV-411.

Signed-off-by: eric-lee-ltk <lidagang1@huawei.com>
@eric-lee-ltk
Copy link
Contributor Author

@liubao68 pls review it.

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.2%) to 86.491% when pulling 51dfde3 on eric-lee-ltk:optimize into 0b32070 on ServiceComb:master.

@WillemJiang WillemJiang merged commit 6ebd57f into apache:master Sep 29, 2017
@eric-lee-ltk eric-lee-ltk deleted the optimize branch September 29, 2017 06:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants