fixed typos and removed unnecessary imports #180
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: eric-lee-ltk <lidagang1@huawei.com>
liubao68
approved these changes
Oct 10, 2017
WillemJiang
reviewed
Oct 10, 2017
|
|
||
| String nameKey = "name"; | ||
|
|
||
| String qulifiedServiceNameKey = serviceDescriptionKey + "." + nameKey; |
There was a problem hiding this comment.
It could be better if we use the up case letter to specify the constant string name. Such as QUALIFIED_SERVICE_NAME_KEY can let the user know it's a constant string.
There was a problem hiding this comment.
It seems constants in DefinitionConst.java are all in camel case. Besides, there are some duplicate constants in DefinitionConst.java and ServiceCombConstants.java. Maybe another PR for this as it may affect others and this PR is mainly focus on misspell issues?
There was a problem hiding this comment.
OK， you can fill a JIRA to check this issue.
WillemJiang
approved these changes
Oct 10, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: eric-lee-ltk lidagang1@huawei.com