[JAV-397] Add automatic signing of release on tagged builds #181
Conversation
| <id>release</id> | ||
| <build> | ||
| <plugins> | ||
| <plugin> |
There was a problem hiding this comment.
why do we need to add the config of maven-deploy-plugin?
There was a problem hiding this comment.
yes it is redundant as already while calling mvn deploy we are setting skiptest so this configuration is not required, I will update the changes
.travis.settings.xml
Outdated
| <password>${env.SONATYPE_PASSWORD}</password> | ||
| </server> | ||
| </servers> | ||
| <profiles> |
There was a problem hiding this comment.
This file is not properly indented
There was a problem hiding this comment.
Thanks @liubao68 , I have updated the file with proper indentedation
.travis.yml
Outdated
| - mvn deploy -DskipTests -Prelease -Ppassphrase --settings .travis.settings.xml | ||
| on: | ||
| tags: true | ||
| all_branches: true |
There was a problem hiding this comment.
does this mean deploying changes from all branches?
There was a problem hiding this comment.
if there is any tagged commit from any branch then it will deploy with auto-signing
|
|
||
| - mvn clean install -Ddocker.showLogs -Pdocker -Pjacoco -Pit -Pcoverage coveralls:report | ||
| after_success: | ||
| - mvn deploy -DskipTests --settings .travis.settings.xml |
There was a problem hiding this comment.
we need snapshots deployed too on each build, in order to allow testing in demo projects to discover potential bugs before release
There was a problem hiding this comment.
Can we just keep deploying the snapshot there?
There was a problem hiding this comment.
Currently I have made the changes to retain old behaviour and on tagged commit the auto signing will be performed for deploy.
So the current behavior will retain and on tagged build the deploy will be performed by signed jars
.travis.yml
Outdated
| - mvn deploy -DskipTests -Prelease -Ppassphrase --settings .travis.settings.xml | ||
| on: | ||
| tags: true | ||
| all_branches: true |
There was a problem hiding this comment.
is it better to limit release to tag on master only?
There was a problem hiding this comment.
okay, I will update it
5 participants
No description provided.