JAV-228 hidden method should be skipped in swagger method lookup #239
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: eric-lee-ltk <lidagang1@huawei.com>
liubao68
reviewed
Nov 3, 2017
| <artifactId>guava</artifactId> | ||
| </dependency> | ||
| </dependencies> | ||
| <dependency> |
There was a problem hiding this comment.
minor : this file is not properly indented
Signed-off-by: eric-lee-ltk <lidagang1@huawei.com>
liubao68
approved these changes
Nov 3, 2017
wujimin
reviewed
Nov 3, 2017
| for (Method method : cls.getMethods()) { | ||
| if (method.getName().equals(methodName)) { | ||
| if (method.isAnnotationPresent(ApiOperation.class) && | ||
| method.getAnnotation(ApiOperation.class).hidden()) { |
There was a problem hiding this comment.
not so good that associate swagger with reflection
you can do this in swagger generator project
Signed-off-by: eric-lee-ltk <lidagang1@huawei.com>
WillemJiang
approved these changes
Nov 3, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: eric-lee-ltk lidagang1@huawei.com