JAV-30 Auto Configration code for spring-boot-starter-discovery #27

asifdxtreme · 2017-06-13T07:41:30Z

Auto Service Registration for spring-boot-starter-discovery

coveralls · 2017-06-13T07:57:55Z

Coverage decreased (-0.1%) to 81.348% when pulling 8a60196 on asifhuawei:discovery-latest into 8771009 on ServiceComb:master.

seanyinx · 2017-06-13T08:03:55Z

java-chassis-dependencies/pom.xml

 				<version>0.1.0-m2-SNAPSHOT</version>
 			</dependency>
+			<dependency>
+				<groupId>io.servicecomb</groupId>


the conflict resolving with master is not right. these dependencies were missing and removed on master.

okay, will fix it

seanyinx · 2017-06-13T08:04:16Z

java-chassis-dependencies/pom.xml

 				<artifactId>java-chassis-core</artifactId>
 				<version>0.1.0-m2-SNAPSHOT</version>
 			</dependency>
+			<dependency>


same as above

okay, will remove this

seanyinx · 2017-06-13T08:05:16Z

spring-boot-starter/spring-boot-starter-discovery/pom.xml

 			<groupId>io.servicecomb</groupId>
 			<artifactId>provider-springmvc</artifactId>
 		</dependency>
+		<dependency>


grpc module was removed already

okay will remove this

seanyinx · 2017-06-13T08:08:04Z

...very/src/main/java/io/servicecomb/springboot/starter/serviceregistry/CseServiceRegistry.java

+		if (null == this.client) {
+			this.client = RegistryClientFactory.getRegistryClient();
+			try {
+				this.client.init();


please rebase onto branch JAV-30_discovery_client. this method shall not throw any exception.

okay will remove try_catch block

seanyinx · 2017-06-13T08:10:25Z

java-chassis-dependencies/pom.xml

 			</dependency>
+			<dependency>
+			<groupId>org.springframework.cloud</groupId>
+			<artifactId>spring-cloud-netflix-core</artifactId>


indentation is not right

seanyinx · 2017-06-13T08:14:51Z

...t-discovery-client/src/test/java/io/servicecomb/demo/discovery/client/DiscoveryClientIT.java

+		TestMgr.errors().clear();
+	}
+
+	@Test


this test doesn't have much meaning except ensured DiscoveryClient can be started up.

Nothing related to how services discovery with spring cloud integration and load balancing was tested.

We have to be sure we are able to forward requests to corresponding services from zuul with service center

Written demo/IT code for:

To test the discovery of particular micro-service

To test the Zuul Proxy gateway feature to redirect the request to proper micro-service.

coveralls · 2017-06-13T09:08:23Z

Coverage remained the same at 81.448% when pulling 2926655 on asifhuawei:discovery-latest into 8771009 on ServiceComb:master.

coveralls · 2017-06-13T09:10:41Z

Coverage decreased (-0.008%) to 81.441% when pulling 2926655 on asifhuawei:discovery-latest into 8771009 on ServiceComb:master.

WillemJiang · 2017-06-13T12:39:53Z

.../main/java/io/servicecomb/springboot/starter/serviceregistry/CseAutoServiceRegistration.java

@@ -0,0 +1,51 @@
+package io.servicecomb.springboot.starter.serviceregistry;


Please add the license header here.

WillemJiang · 2017-06-13T12:40:16Z

...vicecomb/springboot/starter/serviceregistry/CseAutoServiceRegistrationAutoConfiguration.java

@@ -0,0 +1,28 @@
+package io.servicecomb.springboot.starter.serviceregistry;


License header.

WillemJiang · 2017-06-13T12:41:43Z

...a/io/servicecomb/springboot/starter/serviceregistry/CseServiceRegistryAutoConfiguration.java

 @Configuration
 @ConditionalOnProperty(value = "spring.cloud.service-registry.enabled", matchIfMissing = true)
 @AutoConfigureBefore(ServiceRegistryAutoConfiguration.class)
 public class CseServiceRegistryAutoConfiguration {


We should avoid using CSE any more.

okay once this PR is merged I will re-factor the names and raise another MR immediately, right now the PR code size is big, re-merging/re-basing is adding extra effort.

coveralls · 2017-06-13T15:20:20Z

Coverage remained the same at 81.448% when pulling 3428b76 on asifhuawei:discovery-latest into 8771009 on ServiceComb:master.

coveralls · 2017-06-13T15:42:34Z

Coverage increased (+0.008%) to 81.448% when pulling 687aef9 on asifhuawei:discovery-latest into c1c3866 on ServiceComb:master.

seanyinx · 2017-06-14T01:01:48Z

could you add this <module>demo-spring-boot-discovery</module> to demo-parent to enable it for testing? I can't get it pass on my laptop.

coveralls · 2017-06-14T02:50:09Z

Coverage decreased (-0.7%) to 80.709% when pulling e63d9b6 on asifhuawei:discovery-latest into c1c3866 on ServiceComb:master.

asifdxtreme · 2017-06-14T02:53:02Z

Added the "spring-boot-starter-discovery" and "demo-spring-boot-starter-discovery" in parent pom

coveralls · 2017-06-14T04:49:28Z

Coverage decreased (-0.1%) to 81.297% when pulling 3cfa5af on asifhuawei:discovery-latest into c1c3866 on ServiceComb:master.

coveralls · 2017-06-14T05:32:40Z

Coverage decreased (-1.2%) to 80.246% when pulling 5343dd0 on asifhuawei:discovery-latest into c1c3866 on ServiceComb:master.

coveralls · 2017-06-15T06:44:13Z

Coverage decreased (-0.5%) to 80.96% when pulling 6707f17 on asifhuawei:discovery-latest into c1c3866 on ServiceComb:master.

coveralls · 2017-06-15T07:14:10Z

Coverage decreased (-0.4%) to 81.035% when pulling e5882b9 on asifhuawei:discovery-latest into c1c3866 on ServiceComb:master.

coveralls · 2017-06-15T10:10:09Z

Coverage decreased (-0.4%) to 81.079% when pulling b8c79ca on asifhuawei:discovery-latest into c1c3866 on ServiceComb:master.

coveralls · 2017-06-15T10:38:19Z

Coverage decreased (-0.3%) to 81.097% when pulling bf85e2b on asifhuawei:discovery-latest into c1c3866 on ServiceComb:master.

seanyinx reviewed Jun 13, 2017

View reviewed changes

asifdxtreme force-pushed the discovery-latest branch 2 times, most recently from 67523ca to 2926655 Compare June 13, 2017 08:51

WillemJiang reviewed Jun 13, 2017

View reviewed changes

JAV-30 Auto Configration code for spring-boot-starter-discovery

687aef9

asifdxtreme force-pushed the discovery-latest branch from 3428b76 to 687aef9 Compare June 13, 2017 15:21

Added discovery client in parent pom

e63d9b6

asifdxtreme force-pushed the discovery-latest branch 8 times, most recently from 378d881 to 8da52eb Compare June 14, 2017 11:14

asifdxtreme force-pushed the discovery-latest branch 6 times, most recently from c36d47b to 6707f17 Compare June 15, 2017 06:23

asifdxtreme force-pushed the discovery-latest branch from 6707f17 to e5882b9 Compare June 15, 2017 06:54

asifdxtreme force-pushed the discovery-latest branch 2 times, most recently from f7b3fa1 to ce053f2 Compare June 15, 2017 09:26

Updated the microservice configurations

bf85e2b

asifdxtreme force-pushed the discovery-latest branch from b8c79ca to bf85e2b Compare June 15, 2017 10:18

seanyinx merged commit 7fae760 into apache:master Jun 15, 2017

		@@ -0,0 +1,51 @@
		package io.servicecomb.springboot.starter.serviceregistry;

		@@ -0,0 +1,28 @@
		package io.servicecomb.springboot.starter.serviceregistry;

JAV-30 Auto Configration code for spring-boot-starter-discovery #27

JAV-30 Auto Configration code for spring-boot-starter-discovery #27

Uh oh!

Conversation

asifdxtreme commented Jun 13, 2017

Uh oh!

coveralls commented Jun 13, 2017

Uh oh!

seanyinx Jun 13, 2017 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

coveralls commented Jun 13, 2017

Uh oh!

coveralls commented Jun 13, 2017

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

coveralls commented Jun 13, 2017

Uh oh!

coveralls commented Jun 13, 2017

Uh oh!

seanyinx commented Jun 14, 2017

Uh oh!

coveralls commented Jun 14, 2017

Uh oh!

asifdxtreme commented Jun 14, 2017

Uh oh!

coveralls commented Jun 14, 2017

Uh oh!

coveralls commented Jun 14, 2017

Uh oh!

coveralls commented Jun 15, 2017

Uh oh!

coveralls commented Jun 15, 2017

Uh oh!

coveralls commented Jun 15, 2017

Uh oh!

coveralls commented Jun 15, 2017

Uh oh!

Uh oh!

seanyinx Jun 13, 2017 •

edited

Loading