Skip to content

Conversation

yehevah
Copy link

@yehevah yehevah commented Jun 13, 2017

提供灰度发布能力——修复“!=”匹配问题

@coveralls
Copy link

Coverage Status

Coverage increased (+0.03%) to 81.473% when pulling f80cffe on yehevah:master into c1c3866 on ServiceComb:master.

@seanyinx
Copy link
Member

灰度发布叫dark launch吧……

@yehevah
Copy link
Author

yehevah commented Jun 14, 2017

貌似dark launch听着确实地道一些

@yehevah yehevah changed the title [Issue #269][sdk-grayrelease]提供灰度发布能力——自己修复“!=”匹配问题 [Issue #269][sdk-grayrelease]提供灰度发布能力——修复“!=”匹配问题 Jun 14, 2017
@WillemJiang
Copy link
Member

从代码修改的内容来看,至加了一个NPE的处理, 还有就是最好有单元测试要验证这个问题。

@yehevah
Copy link
Author

yehevah commented Jun 14, 2017

可以,补充单元测试

@coveralls
Copy link

Coverage Status

Coverage increased (+0.4%) to 82.028% when pulling 230b10b on yehevah:master into f5c55a8 on ServiceComb:master.

@TankTian
Copy link
Contributor

Issue #269 这个跟踪号,外部看不懂,请用外部jira跟踪或者在当前库提交issue。

@TankTian TankTian closed this Jun 28, 2017
@TankTian TankTian reopened this Jun 28, 2017
@WillemJiang
Copy link
Member

Please rebase to resolve the conflict instead of using merge command.
There are too many changes in the last commit.

@apache apache deleted a comment from liubao68 Jul 1, 2017
@WillemJiang
Copy link
Member

This part of function is removed due to relay on some internal service.

@WillemJiang WillemJiang closed this Jul 1, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants