Skip to content

JAV-104 clean up unused methods whose tests fail on windows #38

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 21, 2017
Merged

JAV-104 clean up unused methods whose tests fail on windows #38

merged 1 commit into from
Jun 21, 2017

Conversation

seanyinx
Copy link
Member

No description provided.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.05%) to 81.671% when pulling dea9900 on JAV-104_code_cleanup into f5c55a8 on master.

liubao68
liubao68 reviewed Jun 21, 2017
View reviewed changes
foundation-common/src/main/java/io/servicecomb/foundation/common/utils/FortifyUtils.java

package io.servicecomb.foundation.common.utils;

import java.io.File;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we'd better to remove this class in the future, some of methods in this class, like xml processing can also be deleted.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

planning to do so

@seanyinx seanyinx merged commit e5bba88 into master Jun 21, 2017
@seanyinx seanyinx deleted the JAV-104_code_cleanup branch June 21, 2017 06:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@liubao68 liubao68 liubao68 left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@seanyinx @coveralls @liubao68