Skip to content

[JAV-566] report type/version when register to SC #406

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 0 commits into from
Closed

[JAV-566] report type/version when register to SC #406

wants to merge 0 commits into from

Conversation

weichao666
Copy link
Contributor

  1. Sdk report their framework type and version when register to SC
  2. Each service with specific version has a certain framework+version
  3. Present the type/version information in console in Service+Version level
  4. In gov service, send the different command to CC according to the type/version when doing management

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.02%) to 86.841% when pulling 50e2c05 on weichao666:master into e9668a4 on ServiceComb:master.

WillemJiang
WillemJiang reviewed Dec 11, 2017
View reviewed changes
...ndation-common/src/main/java/io/servicecomb/foundation/common/base/ServiceCombConstants.java Outdated

String CONFIG_MICROSERVCIE_DEVELOPMENT_FRAMEWORK_VERSION_KEY = "framework.version";

String CONFIG_MICROSERVICE_REGISTER_WAY_KEY = "registreBy";
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It should be registeredBy

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, the spelling is wrong here,it has been changed to registerBy,it's sure better to use registeredBy, but this field is provided by SC, i have to align with them...

service-registry/src/main/java/io/servicecomb/serviceregistry/api/registry/Microservice.java Outdated

private Map<String, String> framework = new HashMap<>();

private String registerBy;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same typo here.

service-registry/src/main/java/io/servicecomb/serviceregistry/api/registry/Microservice.java Outdated
this.framework = framework;
}

public String getRegisterBy() {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

typo

@coveralls
Copy link

Coverage Status

Coverage increased (+0.01%) to 86.869% when pulling fad6126 on weichao666:master into e9668a4 on ServiceComb:master.

@weichao666 weichao666 changed the title [JAV_XXX] report type/version when register to SC [JAV-566] report type/version when register to SC Dec 12, 2017
@weichao666 weichao666 closed this Dec 12, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@WillemJiang WillemJiang WillemJiang left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@weichao666 @coveralls @WillemJiang