[JAV-127]retry的场景在自己的线程池执行 #41
Conversation
| public class LoadbalanceHandler extends AbstractHandler { | ||
| private static final Logger LOGGER = LoggerFactory.getLogger(LoadbalanceHandler.class); | ||
|
|
||
| private static final ExecutorService RETRY_POOL = Executors.newCachedThreadPool(new ThreadFactory() { |
There was a problem hiding this comment.
It could be better to use fix size thread pool to avoid the resource leak.
There was a problem hiding this comment.
This Is not a resource leak stuff, but a performance stuff I think. And I.think it's better to use a cached pool to reuse in high volume request and when no requests thread will be destroyed automatically
| @Override | ||
| public void execute(Runnable command) { | ||
| command.run(); // retry的场景，对于同步调用， 需要在网络线程中进行。同步调用的主线程已经被挂起，无法再主线程中进行重试。 | ||
| // retry的场景，对于同步调用, 同步调用的主线程已经被挂起，无法再主线程中进行重试; |
There was a problem hiding this comment.
can you reproduce this issue in a test and ensure it's fixed in the new solution?
There was a problem hiding this comment.
It's quite easy to reproduce according to the issue discretion, and I have test it.
There was a problem hiding this comment.
start a producer to listen to both rpc/highway, and a rest api that throws an exception. start a consumer with load balance retry enabled, and call this method
There was a problem hiding this comment.
great, could you please add an automated test to ensure it won't be broken by changes in the future?
add test case
modify test case
No description provided.