Skip to content

[JAV-576] The service instance state can‘t be invoked by the client when it is DOWN #439

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 4 commits into from
Closed

[JAV-576] The service instance state can‘t be invoked by the client when it is DOWN #439

wants to merge 4 commits into from

Conversation

weichao666
Copy link
Contributor

sdk在push和pull时需要作判断,sdk不访问实例状态为DOWN的实例

@weichao666 weichao666 changed the title [JAV576] 服务实例状态为DOWN时能被客户端正常调用 [JAV576] The service instance state can‘t be invoked by the client when it is DOWN Dec 15, 2017
@coveralls
Copy link

Coverage Status

Coverage increased (+0.01%) to 86.762% when pulling bb721f3 on weichao666:CSE958 into 4d7e61d on ServiceComb:master.

eric-lee-ltk
eric-lee-ltk reviewed Dec 15, 2017
View reviewed changes
...ice-registry/src/main/java/io/servicecomb/serviceregistry/cache/InstanceCacheManagerOld.java Outdated
cacheMap.put(key, new InstanceCache(appId, microserviceName, version, instMap));
break;
}
instMap.put(changedEvent.getInstance().getInstanceId(), changedEvent.getInstance());
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

how about putting this line in the else clause to avoid duplicate statement of line 155 and 159?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

@WillemJiang WillemJiang changed the title [JAV576] The service instance state can‘t be invoked by the client when it is DOWN [JAV-576] The service instance state can‘t be invoked by the client when it is DOWN Dec 15, 2017
@coveralls
Copy link

Coverage Status

Coverage increased (+0.01%) to 86.733% when pulling dc6e62d on weichao666:CSE958 into 72407ed on ServiceComb:master.

@liubao68
Copy link
Contributor

Please check #449 for more details

wujimin
wujimin reviewed Dec 19, 2017
View reviewed changes
Copy link
Contributor

@wujimin wujimin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we already done this in:
io.servicecomb.serviceregistry.cache.InstanceCache.createTransportMap()
io.servicecomb.serviceregistry.consumer.MicroserviceVersions.setInstances(List)

what's the existing problem?

liubao68
liubao68 requested changes Dec 20, 2017
View reviewed changes
Copy link
Contributor

@liubao68 liubao68 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

check mentioned issues, already done in new implementation

@weichao666 weichao666 closed this Dec 21, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eric-lee-ltk eric-lee-ltk eric-lee-ltk left review comments

@wujimin wujimin wujimin left review comments

@liubao68 liubao68 liubao68 requested changes

@WillemJiang WillemJiang WillemJiang approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@weichao666 @coveralls @liubao68 @WillemJiang @eric-lee-ltk @wujimin