[JAV-136]在发生异常，执行fallback的时候，没有打印原始异常，问题定位非常不方便 #50
Conversation
| return e; //by default, just pass through | ||
| } | ||
| }); | ||
| } catch (Exception e) { |
There was a problem hiding this comment.
only catch exception type thrown by the method called
There was a problem hiding this comment.
no exception defined by this method, only RuntimeException will throw by this method. Here we ignore any runtimeexception thrown by this method and only give a warning.
There was a problem hiding this comment.
it throws IllegalStateException and we shall only catch this one.
There was a problem hiding this comment.
I don't think it's a good practice. Because IllegalStateException is thrown internally, we don't know what's it if we don't check the source code. This rule is acceptable when the exception is declared by the method implicitly and not a RuntimeException. When we deal with RuntimeException, we'd better to use generic exception type, It's better for code quality.
There was a problem hiding this comment.
As you don't log the actual exception message, it could mislead the user if the RuntimeException is not related to HystrixCommandExcecution hook setting.
4 participants
No description provided.