[JAV-140]Provider需要支持全局限流能力 #54
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
seanyinx
reviewed
Jun 26, 2017
| * See the License for the specific language governing permissions and | ||
| * limitations under the License. | ||
| * Unless required by applicable law or agreed to in writing, software distributed under the License | ||
| * is distributed on an "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express |
There was a problem hiding this comment.
the format of copyright is not supposed to be changed
WillemJiang
reviewed
Jun 28, 2017
| validAssert = true; | ||
| handler.handle(invocation, asyncResp); | ||
| handler.handle(invocation, asyncResp); | ||
| } catch (Exception e) { |
There was a problem hiding this comment.
We don't need to catch the exception here, the test could be failed if the exception is thrown.
There was a problem hiding this comment.
This is an old test case that remains untouched. It is logically correct, not modify it now.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.