JAV-105 create microservice from definition #58
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
create microservice from microservice definition, and save them in MicroserviceManager |
WillemJiang
reviewed
Jun 27, 2017
| private static final Logger LOGGER = LoggerFactory.getLogger(RegistryUtils.class); | ||
|
|
||
| // temp field | ||
| private static MicroserviceManager microserviceManager; |
There was a problem hiding this comment.
It's not thread safe if there are multiple thread init the microserviceManager.
There was a problem hiding this comment.
only be inited when cse start, and only init once.
There was a problem hiding this comment.
and all about this field code is temp
all will be changed after the follow PR.
WillemJiang
reviewed
Jun 27, 2017
| import io.servicecomb.serviceregistry.definition.MicroserviceDefinition; | ||
|
|
||
| public class TestPropertiesLoader { | ||
| private static MicroserviceManager microserviceManager = new MicroserviceManager();; |
|
Changes Unknown when pulling 1e6a826 on wujimin:create-from-definition into ** on ServiceComb:master**. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.