Jav 123 rest tracing #60

seanyinx · 2017-06-29T08:38:44Z

@liubao68 @wujimin

coveralls · 2017-06-29T10:37:53Z

Coverage decreased (-0.07%) to 84.582% when pulling c18649e on JAV-123_rest_tracing into b3edf38 on master.

coveralls · 2017-06-29T12:04:48Z

Coverage decreased (-0.08%) to 84.574% when pulling 9ddf15e on JAV-123_rest_tracing into b3edf38 on master.

coveralls · 2017-06-29T12:24:04Z

Coverage decreased (-0.08%) to 84.574% when pulling b132725 on JAV-123_rest_tracing into b3edf38 on master.

seanyinx · 2017-07-02T01:06:59Z

this PR is on top of #65 and #65 shall be merged first

coveralls · 2017-07-02T01:46:19Z

Coverage decreased (-0.2%) to 84.525% when pulling 29b2156 on JAV-123_rest_tracing into 464cb72 on master.

coveralls · 2017-07-02T02:41:17Z

Coverage decreased (-0.3%) to 84.433% when pulling 7a56071 on JAV-123_rest_tracing into 464cb72 on master.

coveralls · 2017-07-03T04:13:35Z

Coverage increased (+0.06%) to 84.831% when pulling 3467fa0 on JAV-123_rest_tracing into 464cb72 on master.

…notation to intercept existing rest templates

coveralls · 2017-07-03T08:08:19Z

Coverage decreased (-0.03%) to 84.831% when pulling 7f82fb9 on JAV-123_rest_tracing into ec3f374 on master.

liubao68 · 2017-07-03T12:38:10Z

foundation-config/src/main/java/io/servicecomb/config/ConfigurationSpringInitializer.java

        }
        return properties;
    }
+


ConfigUtil.installDynamicConfig() is duplicate with bean inialization.

sorry, could you elaborate a bit? I didn't get what you mean.

这个只是逻辑上有点绕，感觉不是很顺，功能上没问题。ConfigUtil.installDynamicConfig和DynamicPropertiesImpl(AbstractConfiguration... configurations) 做的是同一个事情。DynamicPropertiesImpl只不过现在初始化的时候，没有调用ConfiguratioinManager.install。从整个系统来看，初始化配置的过程还是由ConfigUtil.installDynamicConfig完成的。

the idea of DynamicProperties here is to replace direct use of archaius classes in our code, so that the testing and extending our framework to support other dynamic configurations, such as disconf, can be done without modification to our framework code.

liubao68 · 2017-07-03T12:39:35Z

foundation-config/src/main/java/io/servicecomb/config/DynamicPropertiesImpl.java

+  DynamicPropertiesImpl() {
+  }
+
+  DynamicPropertiesImpl(AbstractConfiguration... configurations) {


unused consturctor

this constructor is called in testing

TankTian · 2017-07-06T16:23:01Z

foundation-config/src/test/java/io/servicecomb/config/DynamicPropertiesTest.java

+import com.netflix.config.ConcurrentMapConfiguration;
+import com.netflix.config.ConfigurationManager;
+import com.netflix.config.DynamicPropertyFactory;
+import com.seanyinx.github.unit.scaffolding.Poller;


this code(com.seanyinx.*) , is it persional code ? is it ok?

seanyinx force-pushed the JAV-123_rest_tracing branch from 7558aea to c18649e Compare June 29, 2017 10:10

seanyinx changed the title ~~Jav 123 rest tracing~~ WIP Jav 123 rest tracing Jun 29, 2017

seanyinx force-pushed the JAV-123_rest_tracing branch 2 times, most recently from b6194d0 to 9ddf15e Compare June 29, 2017 11:52

seanyinx force-pushed the JAV-123_rest_tracing branch from 9ddf15e to b132725 Compare June 29, 2017 12:05

seanyinx changed the title ~~WIP Jav 123 rest tracing~~ Jav 123 rest tracing Jun 30, 2017

seanyinx requested a review from WillemJiang June 30, 2017 01:07

seanyinx mentioned this pull request Jun 30, 2017

Jav 157 rest template overrides #63

Closed

seanyinx force-pushed the JAV-123_rest_tracing branch from b132725 to 336f5fb Compare July 2, 2017 01:04

seanyinx force-pushed the JAV-123_rest_tracing branch from 29b2156 to 7a56071 Compare July 2, 2017 02:23

seanyinx requested review from wujimin and liubao68 July 3, 2017 04:24

seanyinx added 11 commits July 3, 2017 15:47

JAV-123 minor code tidy up

77279be

JAV-123 added tracing module for spring mvc

0d77650

JAV-123 set up tracing with zipkin for spring mvc

aa2374d

JAV-123 added test case to cover servlet tracing

b4ae6d6

JAV-123 able to trace servlet request

347eec3

JAV-123 made sure tracing ids are inherited from parent to child

4a822aa

JAV-123 reusing jvm in surefire may cause test using statics to fail

2f19f1d

JAV-123 ignored test of unimplemented feature

878b3b9

JAV-123 added option to disable log merging

09f1d61

JAV-123 reformat and try to fix concurrent issue of test

64a0951

JAV-123 clean up archaius after test

4054b27

seanyinx added 6 commits July 3, 2017 15:47

JAV-123 tracing test on jaxrs with servlet and tracing config with an…

30d72d3

…notation to intercept existing rest templates

JAV-123 implemented zipkin tracing handler

0b47f03

JAV-123 standardized tracing with handler chain

7ef7da5

JAV-123 fetched properties from archaius

9e17aef

JAV-123 removed duplicate tests, since we are tapping on invocation

dfe8916

JAV-123 added zipkin tracing module to coverage reports

7f82fb9

seanyinx force-pushed the JAV-123_rest_tracing branch from 3467fa0 to 7f82fb9 Compare July 3, 2017 07:50

liubao68 reviewed Jul 3, 2017

View reviewed changes

liubao68 approved these changes Jul 3, 2017

View reviewed changes

WillemJiang approved these changes Jul 4, 2017

View reviewed changes

wujimin approved these changes Jul 4, 2017

View reviewed changes

seanyinx merged commit ea1abe5 into master Jul 4, 2017

seanyinx deleted the JAV-123_rest_tracing branch July 4, 2017 07:36

TankTian reviewed Jul 6, 2017

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Jav 123 rest tracing #60

Jav 123 rest tracing #60

Uh oh!

seanyinx commented Jun 29, 2017 •

edited

Loading

Uh oh!

coveralls commented Jun 29, 2017

Uh oh!

coveralls commented Jun 29, 2017

Uh oh!

coveralls commented Jun 29, 2017

Uh oh!

seanyinx commented Jul 2, 2017

Uh oh!

coveralls commented Jul 2, 2017

Uh oh!

coveralls commented Jul 2, 2017

Uh oh!

coveralls commented Jul 3, 2017

Uh oh!

coveralls commented Jul 3, 2017

Uh oh!

liubao68 Jul 3, 2017 •

edited

Loading

Uh oh!

seanyinx Jul 4, 2017

Uh oh!

liubao68 Jul 4, 2017

Uh oh!

seanyinx Jul 4, 2017

Uh oh!

liubao68 Jul 3, 2017

Uh oh!

seanyinx Jul 4, 2017 •

edited

Loading

Uh oh!

TankTian Jul 6, 2017

Uh oh!

Uh oh!

Jav 123 rest tracing #60

Jav 123 rest tracing #60

Uh oh!

Conversation

seanyinx commented Jun 29, 2017 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

coveralls commented Jun 29, 2017

Uh oh!

coveralls commented Jun 29, 2017

Uh oh!

coveralls commented Jun 29, 2017

Uh oh!

seanyinx commented Jul 2, 2017

Uh oh!

coveralls commented Jul 2, 2017

Uh oh!

coveralls commented Jul 2, 2017

Uh oh!

coveralls commented Jul 3, 2017

Uh oh!

coveralls commented Jul 3, 2017

Uh oh!

liubao68 Jul 3, 2017 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

seanyinx Jul 4, 2017

Choose a reason for hiding this comment

Uh oh!

liubao68 Jul 4, 2017

Choose a reason for hiding this comment

Uh oh!

seanyinx Jul 4, 2017

Choose a reason for hiding this comment

Uh oh!

liubao68 Jul 3, 2017

Choose a reason for hiding this comment

Uh oh!

seanyinx Jul 4, 2017 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

TankTian Jul 6, 2017

Choose a reason for hiding this comment

Uh oh!

Uh oh!

seanyinx commented Jun 29, 2017 •

edited

Loading

liubao68 Jul 3, 2017 •

edited

Loading

seanyinx Jul 4, 2017 •

edited

Loading