Skip to content

Conversation

TankTian
Copy link
Contributor

@TankTian TankTian commented Jul 4, 2017

No description provided.

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.05%) to 84.806% when pulling 4ce391a on TankTian:master into ec3f374 on ServiceComb:master.

pom.xml Outdated
<module>common</module>
<module>foundation</module>
<module>handler</module>
<module>provider</module>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can we rename parent module from handler to handlers, provider -> providers, transport -> transports?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok

@coveralls
Copy link

Coverage Status

Coverage increased (+0.04%) to 84.869% when pulling e3b0cae on TankTian:master into ea1abe5 on ServiceComb:master.

@@ -0,0 +1 @@
/bin/
Copy link
Member

@seanyinx seanyinx Jul 4, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why adding this file?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

mistake,maybe eclipse auto generate.later ,i will remove it .

@seanyinx seanyinx merged commit 13b8af8 into apache:master Jul 4, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants