[JAV-161]负载均衡模块每次请求都会加载filter, 修改为loadbalance创建的时候创建一次 #70
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
seanyinx
reviewed
Jul 5, 2017
|
|
||
| @BeforeClass | ||
| public static void initConfig() throws Exception { | ||
| ConfigUtil.installDynamicConfig(); |
There was a problem hiding this comment.
could you clean up archaius after use? or other places using it may fail
WillemJiang
reviewed
Jul 5, 2017
| isolationListFilter.setMicroserviceName(invocation.getMicroserviceName()); | ||
| isolationListFilter.setMicroserviceName(microserviceName); | ||
| isolationListFilter.setLoadBalancerStats(lb.getLoadBalancerStats()); | ||
| lb.putFilter(filterName, isolationListFilter); |
There was a problem hiding this comment.
一个lb只能接受一个isolationListFilter吧， 但是从上面的setIsolcationFilter的调用接口来看，是可以设置多个microservicename的。
There was a problem hiding this comment.
一个miscroservername对应一个LB实例，每个LB实例都可以设置isolationListFilter
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.