JAV-88 added springmvc tests to verify springmvc endpoints only #74
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
liubao68
reviewed
Jul 7, 2017
| public class SpringMvcIntegrationTest { | ||
|
|
||
| private final String baseUrl = "http://127.0.0.1:8080/"; | ||
| private final RestTemplate restTemplate = new RestTemplate(); |
There was a problem hiding this comment.
All requests go direct to server, and not pass handler chain. Should we use RestTemplateBuilder to create invocation?
There was a problem hiding this comment.
you mean consumer handler chain right? we are trying to test provider (including its handler chain) in isolation.
seanyinx
approved these changes
Jul 10, 2017
liubao68
approved these changes
Jul 14, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
added tests to verify springmvc endpoints only