removed redundant validation logic #77
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
seanyinx
reviewed
Jul 17, 2017
| conf.getString(DefinitionConst.qulifiedServiceNameKey, DefinitionConst.defaultMicroserviceName); | ||
| if (!StringUtils.isEmpty(name)) { | ||
| checkMicroserviceName(name); | ||
| combinedFrom.add(name); |
There was a problem hiding this comment.
do we have corresponding test to verify that this is indeed redundant?
There was a problem hiding this comment.
seems like there has no unit tests for this class and no test covers this scene.
There was a problem hiding this comment.
combinedFrom will throw NPE when name is null and the logic is different after change when name is empty
eric-lee-ltk
changed the title
seanyinx
requested changes
Jul 18, 2017
| conf.getString(DefinitionConst.qulifiedServiceNameKey, DefinitionConst.defaultMicroserviceName); | ||
| if (!StringUtils.isEmpty(name)) { | ||
| checkMicroserviceName(name); | ||
| combinedFrom.add(name); |
There was a problem hiding this comment.
combinedFrom will throw NPE when name is null and the logic is different after change when name is empty
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
method
checkMicroserviceNamehas already validate whether name is empty or not, there is no need to validate it again, right?