Jav 163 zuul tracing #86
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
seanyinx
force-pushed
the
JAV-163_zuul_tracing
branch
2 times, most recently
from
8e2408a to
fc2d684
Compare
|
Changes Unknown when pulling fc2d684 on JAV-163_zuul_tracing into ** on master**. |
seanyinx
force-pushed
the
JAV-163_zuul_tracing
branch
from
fc2d684 to
2465e7c
Compare
seanyinx
force-pushed
the
JAV-163_zuul_tracing
branch
from
255b06b to
4720888
Compare
seanyinx
force-pushed
the
JAV-163_zuul_tracing
branch
from
93bd261 to
650283e
Compare
|
Changes Unknown when pulling 650283e on JAV-163_zuul_tracing into ** on master**. |
WillemJiang
reviewed
Jul 19, 2017
| <dependencies> | ||
| <dependency> | ||
| <groupId>io.servicecomb.tests</groupId> | ||
| <artifactId>test-common</artifactId> |
There was a problem hiding this comment.
If the test common is used by other test, it could be better we just put the code into main/src.
Because we normally don't release the test jar.
There was a problem hiding this comment.
users don't need to use test common, right? it's to share common test scaffolding in our integration tests
| @Override | ||
| public void doFilter(ServletRequest servletRequest, ServletResponse servletResponse, FilterChain filterChain) | ||
| throws IOException, ServletException { | ||
| logger.info("logged tracing filter"); |
There was a problem hiding this comment.
It could be better if we can log more information about request and response here.
There was a problem hiding this comment.
this is just for testing to grab the tracing logs
wujimin
approved these changes
Jul 19, 2017
seanyinx
force-pushed
the
JAV-163_zuul_tracing
branch
from
650283e to
7361c54
Compare
liubao68
approved these changes
Jul 19, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.