Skip to content

Conversation

eric-lee-ltk
Copy link
Contributor

resolved port conflict between tomcat and vertx.

  1. extract EnableServiceComb Annotation and common dependencies of provider and transport to a new module named spring-boot-starter-servicecomb.
  2. disable tomcat auto start when using vertx only in case of port conflict
  3. now spring-boot-starter-provider provides vertx transport dependencies while spring-boot-starter-transport provides servlet transport dependencies.

Cautious: If we need both servlet and vertx to work under spring framework, please set application.properties to be spring.main.web-environment=true and avoid servlet and vertx using the same port, e.g. 8080.

@eric-lee-ltk eric-lee-ltk force-pushed the JAV-90_starter_port_conflict branch from 1f45703 to 19db726 Compare July 21, 2017 07:48
@coveralls
Copy link

Coverage Status

Coverage decreased (-0.01%) to 85.209% when pulling 19db726 on eric-lee-ltk:JAV-90_starter_port_conflict into 2afb8c2 on ServiceComb:master.

@seanyinx seanyinx merged commit 64c6562 into apache:master Jul 24, 2017
@eric-lee-ltk eric-lee-ltk deleted the JAV-90_starter_port_conflict branch July 24, 2017 01:33
@WillemJiang WillemJiang modified the milestone: 0.2.0 Aug 19, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants