JAV-196 Configuration of config center url #96
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
make function of ConfigUtil more clear, easy to use.
add test case for reinstall dynamic config checking.
add test case for ConfigUtil lost scenes.
change config center configuration source from WatchedConfigurationSource to new interface: ConfigCenterConfigurationSource provide a "init" method with parameter local config, that avoid config center SPI implementation recreate local config
wujimin
force-pushed
the
configuration-of-config-center-url
branch
from
d21bb04 to
d579954
Compare
|
Changes Unknown when pulling d579954 on wujimin:configuration-of-config-center-url into ** on ServiceComb:master**. |
liubao68
reviewed
Jul 25, 2017
| private static final Logger LOGGER = LoggerFactory.getLogger(ConfigUtil.class); | ||
|
|
||
| private static final String configCenterUrlKey = "cse.config.client.serverUri"; | ||
| protected static final String configCenterUrlKey = "cse.config.client.serverUri"; |
There was a problem hiding this comment.
对于final class，不应该有protected方法
There was a problem hiding this comment.
share for unit test.
|
Hi jiming, there are some changes on the ConfigUtil. Could you update the code and resolve the conflicts? |
…into configuration-of-config-center-url # Conflicts: # foundations/foundation-config/src/main/java/io/servicecomb/config/ConfigUtil.java # foundations/foundation-config/src/test/java/io/servicecomb/config/TestConfigUtil.java # foundations/foundation-config/src/test/java/io/servicecomb/config/TestConfigurationSpringInitializer.java
config value maybe a list, can not use getString
|
resolved conflicts |
liubao68
approved these changes
Jul 26, 2017
wujimin
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
1.read config center url from local config data, that include microservice.yaml/additional config/environment/command parameters
2.discuss with config-cc, modify SPI interface, not use WatchedConfigurationSource directly, but extend it, add method: void init(Configuration localConfig), to avoid create another configration instance and reduce api of create configration coupling