JAV-221 make vertx eventloop thread name related to vertx name #97
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
previous name is "vert.x-eventloop-thread-{number}"
new name is "{name}-vert.x-eventloop-thread-{number}"
|
Changes Unknown when pulling ee5356d on wujimin:vertx-eventloop-name into ** on ServiceComb:master**. |
liubao68
reviewed
Jul 25, 2017
|
yes |
|
return Vertx.vertx(vertxOptions) is a factory method , after change, we new a object our self, most of time UT can not guarantee this |
|
UT do not care for this , thread name only for runtime. |
|
just only one test case check the thread name , this case added in this PR |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
previous name is "vert.x-eventloop-thread-{number}"
new name is "{name}-vert.x-eventloop-thread-{number}"