feat: add proxy support to OAuth sessions #89
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vetsin
requested changes
Dec 13, 2023
| @@ -1,6 +1,6 @@ | |||
| [tool.poetry] | |||
| name = "pysnc" | |||
| version = "1.1.6a0" | |||
| version = "1.1.7a0" | |||
There was a problem hiding this comment.
version is auto managed - don't need to manually bump
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi there,
Just an issue that we came into, the proxy or proxies given to the ServiceNowClient are currently not used when authenticating using OAuth, which breaks everything in our use case.
The refactor might not be the cleanest, but works as expected in our environment now. Feel free to request any modification on my side to make it fit your requirements.
Cheers.