Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test various front-end components #224

Merged
merged 11 commits into from
Jan 24, 2023

Conversation

nandhinibsn
Copy link
Contributor

Resolve #

Description:

Checklist:

You should check all boxes before the PR is ready. If a box does not apply, check it to acknowledge it.

  • ISSUE NUMBER. You linked the issue number (Ex: Resolve #XXX).
  • PRE-COMMIT. You ran pre-commit on all commits, or else, you
    ran pre-commit run --all-files at the end.
  • FRONTEND TYPES. Regenerate the front-ent types if you played with types and routes.
    Run cd webapp && yarn types while the back-end is running.
  • USER CHANGES. The changes are added to CHANGELOG.md and the documentation, if they impact
    our users.
  • DEV CHANGES.
    • Update the documentation if this PR changes how to develop/launch on the app.
    • Update the README files and our wiki for any big design decisions, if relevant.
    • Add unit tests, docstrings, typing and comments for complex sections.

@nandhinibsn nandhinibsn force-pushed the nandhini/test-performance-analysis-table branch from d13e47a to 2a00088 Compare August 22, 2022 15:25
@gabegma
Copy link
Contributor

gabegma commented Dec 7, 2022

Is this PR still relevant @nandhinibsn@JosephMarinier? It's been open for 4 months. Maybe we could prioritize it if we have some slack this sprint?

webapp/package.json Outdated Show resolved Hide resolved
@JosephMarinier JosephMarinier changed the title Nandhini/test performance analysis table Test various front-end components Jan 20, 2023
@JosephMarinier
Copy link
Contributor

I renamed the PR to take testing the performance analysis table out of its scope. This PR has waited long enough now and those tests will be beneficial.

@nandhinibsn nandhinibsn force-pushed the nandhini/test-performance-analysis-table branch from d3d21b1 to 189f3bd Compare January 23, 2023 22:02
).toBeInTheDocument();
});

it("should not display the Footer component if the number of rows are lesser than initial number", async () => {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you mean

Suggested change
it("should not display the Footer component if the number of rows are lesser than initial number", async () => {
it("should not display the Footer component if the number of rows is less than initial number", async () => {

but I'm not following. What initial number? The test doesn't manipulate anything, so I guess this is the initial number of rows, not less. Can you help me understand?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I meant the same "INITIAL_NUMBER_VISIBLE = 5", as we mentioned in our logic. This test case will check if there should be no footer component displayed. The mock response that was added is at most four rows.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Got it, thanks!

Copy link
Contributor

@JosephMarinier JosephMarinier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool! Thanks for doing that!

@nandhinibsn nandhinibsn merged commit fb1add5 into main Jan 24, 2023
@nandhinibsn nandhinibsn deleted the nandhini/test-performance-analysis-table branch January 24, 2023 15:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants