-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Test various front-end components #224
Conversation
d13e47a
to
2a00088
Compare
Is this PR still relevant @nandhinibsn@JosephMarinier? It's been open for 4 months. Maybe we could prioritize it if we have some slack this sprint? |
I renamed the PR to take testing the performance analysis table out of its scope. This PR has waited long enough now and those tests will be beneficial. |
2a00088
to
d3d21b1
Compare
d3d21b1
to
189f3bd
Compare
).toBeInTheDocument(); | ||
}); | ||
|
||
it("should not display the Footer component if the number of rows are lesser than initial number", async () => { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think you mean
it("should not display the Footer component if the number of rows are lesser than initial number", async () => { | |
it("should not display the Footer component if the number of rows is less than initial number", async () => { |
but I'm not following. What initial number? The test doesn't manipulate anything, so I guess this is the initial number of rows, not less. Can you help me understand?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I meant the same "INITIAL_NUMBER_VISIBLE = 5", as we mentioned in our logic. This test case will check if there should be no footer component displayed. The mock response that was added is at most four rows.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Got it, thanks!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Cool! Thanks for doing that!
Resolve #
Description:
Checklist:
You should check all boxes before the PR is ready. If a box does not apply, check it to acknowledge it.
ran
pre-commit run --all-files
at the end.Run
cd webapp && yarn types
while the back-end is running.our users.
README
files and our wiki for any big design decisions, if relevant.