Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove warnings from GitHub actions #326

Merged
merged 3 commits into from
Dec 7, 2022
Merged

Conversation

gabegma
Copy link
Contributor

@gabegma gabegma commented Dec 5, 2022

Resolve #

Description:

We have a few warnings in our GitHub actions. We cannot remove them all because they are part of the actions that we use, but I removed the ones in our scripts.
From https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/

Checklist:

You should check all boxes before the PR is ready. If a box does not apply, check it to acknowledge it.

  • ISSUE NUMBER. You linked the issue number (Ex: Resolve #XXX).
  • PRE-COMMIT. You ran pre-commit on all commits, or else, you
    ran pre-commit run --all-files at the end.
  • USER CHANGES. The changes are added to CHANGELOG.md and the documentation, if they impact
    our users.
  • DEV CHANGES.
    • Update the documentation if this PR changes how to develop/launch on the app.
    • Update the README files and our wiki for any big design decisions, if relevant.
    • Add unit tests, docstrings, typing and comments for complex sections.

@gabegma gabegma changed the title Update webapp_ci.yml Remove warnings from GitHub actions Dec 5, 2022
@gabegma gabegma marked this pull request as ready for review December 6, 2022 22:44
Copy link
Contributor

@JosephMarinier JosephMarinier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's actually very elegant. 👍

@gabegma gabegma merged commit aca5dbd into main Dec 7, 2022
@gabegma gabegma deleted the ggm/remove-warnings-gh-actions branch December 7, 2022 19:06
JosephMarinier pushed a commit that referenced this pull request Dec 20, 2022
* Update webapp_ci.yml

* Update docs_cd.yml

* Update docker_cd.yml
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants