Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve config page display when values are null #374

Merged
merged 5 commits into from
Jan 16, 2023

Conversation

nandhinibsn
Copy link
Contributor

@nandhinibsn nandhinibsn commented Jan 12, 2023

Resolve #

Description:

Referring to this PR - #366

Checklist:

You should check all boxes before the PR is ready. If a box does not apply, check it to acknowledge it.

  • ISSUE NUMBER. You linked the issue number (Ex: Resolve #XXX).
  • PRE-COMMIT. You ran pre-commit on all commits, or else, you
    ran pre-commit run --all-files at the end.
  • USER CHANGES. The changes are added to CHANGELOG.md and the documentation, if they impact
    our users.
  • DEV CHANGES.
    • Update the documentation if this PR changes how to develop/launch on the app.
    • Update the README files and our wiki for any big design decisions, if relevant.
    • Add unit tests, docstrings, typing and comments for complex sections.

@JosephMarinier
Copy link
Contributor

JosephMarinier commented Jan 12, 2023

In the future, please don't close and re-open PRs just to rename the branch. It makes us lose our review conversation. It also closed my PR that was based on yours and deleted my branch.

@nandhinibsn
Copy link
Contributor Author

In the future, please don't close and re-open PRs just to rename the branch. It makes us lose our review conversation. It also closed my PR that was based on yours and deleted my branch.

Sure, I was not aware it would create a new branch and close the old one. That's why I did not change the branch names for my other PRs

Copy link
Contributor

@JosephMarinier JosephMarinier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@JosephMarinier JosephMarinier enabled auto-merge (squash) January 16, 2023 18:41
@JosephMarinier JosephMarinier merged commit 122eab1 into main Jan 16, 2023
@JosephMarinier JosephMarinier deleted the nandhini/fix/config-page branch January 16, 2023 18:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants