-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add persistent id to front end #385
Conversation
488b45d
to
ed87456
Compare
using a new `BaseUtterance` class to avoid duplication of field definitions.
so for example we see `...001`, `...002`, `...003` (and infer the remaining digits from the page number) instead of `100...`, `100...`, `100...`.
in utterance table, utterance details, and similar utterances.
ed87456
to
63f2255
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great idea for the back end! LGTM for that part.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes looks good to me. It would be very much helpful if you could give me an example of what other columns could be in the "persistent_id" from the config. Secondly, where does azimuth evaluates the column idx?. If you could point me out the code, it would be even more helpful to understand.
The
I'm not sure I understand. What do you mean by "evaluate"? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Okay, thank you! My question was if there is any logic to creating an index for each utterance from Azimuth. |
Ah yes, as we say in this tooltip, it is an "id created by Azimuth". It is assigned sequentially here: azimuth/azimuth/dataset_split_manager.py Lines 260 to 262 in de47555
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Frontend code looks good to me. As discussed, I would still be interested in design input for the UX of persistent ids but we can merge now and improve later.
Resolve #377
Description:
BaseUtterance
class to avoid duplication of field definitions....001
,...002
,...003
(and infer the remaining digits from the page number) instead of100...
,100...
,100...
.Screen.Recording.2023-01-20.at.4.47.52.PM.mov
persistent_id
column (different that Azimuth's defaultrow_idx
), otherwise the tooltip is the same as before.Screen.Recording.2023-01-20.at.4.48.15.PM.mov
Checklist:
You should check all boxes before the PR is ready. If a box does not apply, check it to acknowledge it.
ran
pre-commit run --all-files
at the end.our users.
README
files and our wiki for any big design decisions, if relevant.