Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modify the minimum value to start from 1 for all integer type config fields #394

Merged
merged 1 commit into from
Jan 27, 2023

Conversation

nandhinibsn
Copy link
Contributor

@nandhinibsn nandhinibsn commented Jan 25, 2023

Resolve #

Description:

All Integer type of config fields should start from 1 instead of 0

Checklist:

You should check all boxes before the PR is ready. If a box does not apply, check it to acknowledge it.

  • ISSUE NUMBER. You linked the issue number (Ex: Resolve #XXX).
  • PRE-COMMIT. You ran pre-commit on all commits, or else, you
    ran pre-commit run --all-files at the end.
  • USER CHANGES. The changes are added to CHANGELOG.md and the documentation, if they impact
    our users.
  • DEV CHANGES.
    • Update the documentation if this PR changes how to develop/launch on the app.
    • Update the README files and our wiki for any big design decisions, if relevant.
    • Add unit tests, docstrings, typing and comments for complex sections.

@nandhinibsn nandhinibsn self-assigned this Jan 25, 2023
@nandhinibsn nandhinibsn changed the title Changed the min value starts from 0 for integer config fields Modify the minimum value to start from 0 for all integer type config fields Jan 25, 2023
@nandhinibsn nandhinibsn changed the title Modify the minimum value to start from 0 for all integer type config fields Modify the minimum value to start from 1 for all integer type config fields Jan 25, 2023
Copy link
Contributor

@JosephMarinier JosephMarinier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perfect! 👍

@nandhinibsn nandhinibsn merged commit fb23e98 into main Jan 27, 2023
@nandhinibsn nandhinibsn deleted the nandhini/config-integer-min-values-update branch January 27, 2023 14:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants