Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix back end when updating the config #395

Merged
merged 4 commits into from
Jan 27, 2023
Merged

Conversation

gabegma
Copy link
Contributor

@gabegma gabegma commented Jan 25, 2023

Description:

  • The try and except never worked because MultipleExceptions was inheriting from BaseException and not Exception.
  • The text classification module was broken with no postprocessors.

Checklist:

You should check all boxes before the PR is ready. If a box does not apply, check it to acknowledge it.

  • ISSUE NUMBER. You linked the issue number (Ex: Resolve #XXX).
  • PRE-COMMIT. You ran pre-commit on all commits, or else, you
    ran pre-commit run --all-files at the end.
  • USER CHANGES. The changes are added to CHANGELOG.md and the documentation, if they impact
    our users.
  • DEV CHANGES.
    • Update the documentation if this PR changes how to develop/launch on the app.
    • Update the README files and our wiki for any big design decisions, if relevant.
    • Add unit tests, docstrings, typing and comments for complex sections.

@gabegma gabegma marked this pull request as draft January 25, 2023 22:23
@gabegma gabegma changed the title Fix back-end when updating the config Fix back end when updating the config Jan 25, 2023
@gabegma gabegma self-assigned this Jan 25, 2023
@gabegma gabegma marked this pull request as ready for review January 26, 2023 15:05
@gabegma gabegma added the bug Something isn't working label Jan 26, 2023
Copy link
Contributor

@JosephMarinier JosephMarinier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Woh! 😲 Good catches! 👍

@gabegma gabegma merged commit e45358b into main Jan 27, 2023
@gabegma gabegma deleted the ggm/fix-back-end-updating-config branch January 27, 2023 18:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants