Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove model_contract from artifact_path #402

Merged
merged 1 commit into from
Jan 27, 2023
Merged

Conversation

gabegma
Copy link
Contributor

@gabegma gabegma commented Jan 27, 2023

Description:

  • model-contract was not in the right config scope. It was there for the artifact_path, but as we discussed, we should not include anything that is not related to the dataset in the artifact_path.

Checklist:

You should check all boxes before the PR is ready. If a box does not apply, check it to acknowledge it.

  • ISSUE NUMBER. You linked the issue number (Ex: Resolve #XXX).
  • PRE-COMMIT. You ran pre-commit on all commits, or else, you
    ran pre-commit run --all-files at the end.
  • USER CHANGES. The changes are added to CHANGELOG.md and the documentation, if they impact
    our users.
  • DEV CHANGES.
    • Update the documentation if this PR changes how to develop/launch on the app.
    • Update the README files and our wiki for any big design decisions, if relevant.
    • Add unit tests, docstrings, typing and comments for complex sections.

@gabegma gabegma changed the title Move model-contract in ModelContractConfig and remove from artifact_path Remove model-contract from artifact_path Jan 27, 2023
@gabegma gabegma changed the title Remove model-contract from artifact_path Remove model_contract from artifact_path Jan 27, 2023
Copy link
Contributor

@JosephMarinier JosephMarinier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wow! So model_contract goes in ModelContractConfig 🤯 Who would have thought? 😝 Thank you for fixing this!

@gabegma gabegma merged commit 7126b82 into main Jan 27, 2023
@gabegma gabegma deleted the ggm/model-contract branch January 27, 2023 18:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants