Add all missing analyses config fields #426
Conversation
|
True. this is simpler. I think we can apply these changes. |
| @@ -551,6 +557,7 @@ const Settings: React.FC = () => { | |||
| {displayToggleSectionTitle("similarity", "Similarity")} | |||
| {getAnalysesCustomization("similarity")} | |||
| {displayToggleSectionTitle("behavioral_testing", "Perturbation Testing")} | |||
| {getAnalysesCustomization("behavioral_testing")} | |||
There was a problem hiding this comment.
Do we not hide the section if behavioral testing is null? Do we display default config values if it's null?
There was a problem hiding this comment.
Right, I was waiting for your input here before changing that. What do you think?
There was a problem hiding this comment.
Okay, I'm so sorry I did not respond there. Yes, I do prefer hiding the content; but we disable in similarity and postprocessor. I can handle that disabling part if we are going to follow the pattern of similarity and postprocessor
There was a problem hiding this comment.
No worries!
Right, showing the default values, but grayed out, is also interesting. You have done it for similarity and postprocessor fields, except it doesn't work for read-only fields.
We could fix that. Or we can hide. Maybe we can ask the team in standup tomorrow?
There was a problem hiding this comment.
Yes, sure, we can ask for clarification. True, disable feature is not added to the read-only part.
Description:
Add to the config page all the fields that were missing from the syntax, similarity, and behavioral testing sections.
Checklist:
You should check all boxes before the PR is ready. If a box does not apply, check it to acknowledge it.
ran
pre-commit run --all-filesat the end.our users.
READMEfiles and our wiki for any big design decisions, if relevant.