-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Change the outcome per threshold bar chart to area chart #444
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add `confidenceThreshold` and `utteranceCount` to API response
JosephMarinier
requested review from
gabegma,
christyler3030 and
nandhinibsn
February 16, 2023 16:36
It became unnecessary when I started to render the grid lines only if there is data (since the vertical grid lines depend on data), plus it was problematic when the plot was not on a paper, like it is on its standalone page.
christyler3030
approved these changes
Feb 17, 2023
JosephMarinier
commented
Feb 17, 2023
JosephMarinier
commented
Feb 17, 2023
JosephMarinier
commented
Feb 17, 2023
JosephMarinier
commented
Feb 17, 2023
gabegma
approved these changes
Feb 17, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM for the back end!! Good job! Some minor comments for the raise
, but I'm fine with the current implementation too if you think that it's preferred.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolve #430
Description:
Clean up front-end imports
Clean up
get_dataset_split()
by leveragingsuper()
Compute outcome count at 100% threshold
Return error if post-processing is not available
Draw area chart
confidenceThreshold
andutteranceCount
to API responseAdd a dashed line for current threshold
Log changes
Adapt test to error if post-processing is not available
Checklist:
You should check all boxes before the PR is ready. If a box does not apply, check it to acknowledge it.
ran
pre-commit run --all-files
at the end.our users.
README
files and our wiki for any big design decisions, if relevant.