Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge v2.5.2 #448

Merged
merged 10 commits into from
Feb 16, 2023
Merged

Merge v2.5.2 #448

merged 10 commits into from
Feb 16, 2023

Conversation

gabegma
Copy link
Contributor

@gabegma gabegma commented Feb 16, 2023

Description:

Merge commit for v2.5.2

Checklist:

You should check all boxes before the PR is ready. If a box does not apply, check it to acknowledge it.

  • ISSUE NUMBER. You linked the issue number (Ex: Resolve #XXX).
  • PRE-COMMIT. You ran pre-commit on all commits, or else, you
    ran pre-commit run --all-files at the end.
  • USER CHANGES. The changes are added to CHANGELOG.md and the documentation, if they impact
    our users.
  • DEV CHANGES.
    • Update the documentation if this PR changes how to develop/launch on the app.
    • Update the README files and our wiki for any big design decisions, if relevant.
    • Add unit tests, docstrings, typing and comments for complex sections.

dependabot bot and others added 9 commits December 20, 2022 08:27
Bumps [express](https://github.com/expressjs/express) from 4.17.1 to 4.17.3.
- [Release notes](https://github.com/expressjs/express/releases)
- [Changelog](https://github.com/expressjs/express/blob/master/History.md)
- [Commits](expressjs/express@4.17.1...4.17.3)

---
updated-dependencies:
- dependency-name: express
  dependency-type: direct:production
...

Signed-off-by: dependabot[bot] <support@github.com>

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
* Update webapp_ci.yml

* Update docs_cd.yml

* Update docker_cd.yml
* Update README.md

* Update README.md

Co-authored-by: Joseph Marinier <joseph.marinier@servicenow.com>

Co-authored-by: Joseph Marinier <joseph.marinier@servicenow.com>
* Clean up test utterances
  - Split into unit tests
  - Assert that responses are sorted
* Test sort without postprocessing
* Fix sort without postprocessing
  - Fix sort confidence or prediction without postprocessing while also simplifying the mapping from `UtterancesSortableColumn` to the actual dataset column, since it's no longer 1:1 (it now depends on `without_postprocessing`).
* Polish comment
and iOS browsers as they don't support lookbehind is regular expressions.
and clean up regular expression
@gabegma gabegma changed the title v2.5.2 Merge v2.5.2 Feb 16, 2023
@gabegma gabegma merged commit 216b698 into main Feb 16, 2023
@gabegma gabegma deleted the joseph/v2.5.2 branch February 16, 2023 21:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants