Support dataset-only smart tag analysis #478
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
that way, skipping columns (for example defining columns 1 and 3) won't leave extra gaps in between.
- `classCount` to `row`, as it is of type `Row` and it's not necessarily a label/prediction class since we added per-outcome aggregation; and - `classIndex` to `rowIndex` accordingly.
|
Awesome!!! A few comments on your questions:
|
JosephMarinier
commented
Mar 8, 2023
as our almost-black primary color can look disabled.
JosephMarinier
commented
Mar 8, 2023
Comment on lines
-141
to
+164
| {isPipelineSelected(pipeline) && ( | ||
| <WithDatasetSplitNameState | ||
| defaultDatasetSplitName={firstAvailableDatasetSplit} | ||
| render={(datasetSplitName, setDatasetSplitName) => ( | ||
| <PreviewCard | ||
| title="Smart Tag Analysis" | ||
| to={`/${jobId}/dataset_splits/${datasetSplitName}/smart_tags${searchString}`} | ||
| description={smartTagsDescription} | ||
| <WithDatasetSplitNameState | ||
| defaultDatasetSplitName={firstAvailableDatasetSplit} | ||
| render={(datasetSplitName, setDatasetSplitName) => ( | ||
| <PreviewCard | ||
| title="Smart Tag Analysis" | ||
| to={`/${jobId}/dataset_splits/${datasetSplitName}/smart_tags${searchString}`} | ||
| description={smartTagsDescription} | ||
| > | ||
| <Box | ||
| display="flex" | ||
| flexDirection="column" // Important for the inner Box to overflow correctly | ||
| maxHeight={DEFAULT_PREVIEW_CONTENT_HEIGHT} | ||
| > | ||
| <Box | ||
| display="flex" | ||
| flexDirection="column" // Important for the inner Box to overflow correctly | ||
| maxHeight={DEFAULT_PREVIEW_CONTENT_HEIGHT} | ||
| > | ||
| <SmartTagsTable | ||
| jobId={jobId} | ||
| pipeline={pipeline} | ||
| availableDatasetSplits={datasetInfo.availableDatasetSplits} | ||
| datasetSplitName={datasetSplitName} | ||
| setDatasetSplitName={setDatasetSplitName} | ||
| /> | ||
| </Box> | ||
| </PreviewCard> | ||
| )} | ||
| /> | ||
| )} | ||
| <SmartTagsTable | ||
| jobId={jobId} | ||
| pipeline={pipeline} | ||
| availableDatasetSplits={datasetInfo.availableDatasetSplits} | ||
| datasetSplitName={datasetSplitName} | ||
| setDatasetSplitName={setDatasetSplitName} | ||
| /> | ||
| </Box> | ||
| </PreviewCard> | ||
| )} | ||
| /> |
There was a problem hiding this comment.
Nothing changed here, except removing the {isPipelineSelected(pipeline) && (...)} around the card. I hate how Git deals with changes of indent.
christyler3030
approved these changes
Mar 9, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolve #433
Description:
The overall diff is pretty messy, so I recommend looking at the different commits individually.
I made a couple of decisions what we can debate:
palette.secondary.dark) like other data visualizations.PredictionandOutcomeoptions from the menu (since hiding the options would result in a weird one-option menu).Here is an example:
For reference, here is how it looks with a pipeline:
Checklist:
You should check all boxes before the PR is ready. If a box does not apply, check it to acknowledge it.
ran
pre-commit run --all-filesat the end.our users.
READMEfiles and our wiki for any big design decisions, if relevant.