Add "created-on" in config history #491
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gabegma
commented
Mar 15, 2023
gabegma
changed the title
gabegma
force-pushed
the
ggm/add-meta-data-in-config-history
branch
2 times, most recently
from
87f8909
to
5e4a2c0
Compare
gabegma
force-pushed
the
ggm/add-meta-data-in-config-history
branch
from
5e4a2c0
to
4ecbdea
Compare
azimuth/config.py
Outdated
| @@ -461,7 +461,8 @@ def load_azimuth_config(config_path: Optional[str], load_config_history: bool) - | |||
| config_history_path = cfg.get_config_history_path() | |||
| try: | |||
| with jsonlines.open(config_history_path, mode="r") as config_history: | |||
| *_, last_config = config_history | |||
| *_, last_config_info = config_history | |||
| last_config = last_config_info["config"] | |||
There was a problem hiding this comment.
If the JSON was malformed, that would raise a KeyError. I don't know if we want that. If we want to let pydantic parse the JSON and produce the "clear" errors, we can create a class like AzimuthConfigHistory. I gave it a try in #493. It also has the advantage of defining how to create the datetime string inside the definition of AzimuthConfigHistory, thanks to default_factory. I don't know what approach is best. What do you think?
JosephMarinier
approved these changes
Mar 16, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
See commit messages.
Checklist:
You should check all boxes before the PR is ready. If a box does not apply, check it to acknowledge it.
ran
pre-commit run --all-filesat the end.our users.
READMEfiles and our wiki for any big design decisions, if relevant.