Support editing lists, args, and kwargs #512
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nandhinibsn
force-pushed
the
nandhini/config_ui_string_editable
branch
from
720b8aa
to
d16611e
Compare
JosephMarinier
force-pushed
the
joseph/lists-args-kwargs
branch
3 times, most recently
from
8bb2172
to
5c3d68a
Compare
JosephMarinier
force-pushed
the
joseph/lists-args-kwargs
branch
from
5c3d68a
to
c26a29e
Compare
| pipelineIndex: number, | ||
| update: Partial<PipelineDefinition["model"]> | ||
| ) => | ||
| setPartialConfig({ |
There was a problem hiding this comment.
Might be safer to use
setPartialConfig(partialConfig => ({...partialConfig, etc...}))
https://react.dev/reference/react/useState#updating-state-based-on-the-previous-state
There was a problem hiding this comment.
Oh cool! I didn't know that existed. 👍
It is like that in more than 20 other places, so I'll make another refactor PR to cover everything.
There was a problem hiding this comment.
If you decide to do the changes in this file in this PR there are a few more instances in this file as well.
There was a problem hiding this comment.
Yeah, yeah, I am just talking about this file: 21 instances of setPartialConfig({ ...partialConfig.
christyler3030
approved these changes
Mar 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Checklist:
You should check all boxes before the PR is ready. If a box does not apply, check it to acknowledge it.
ran
pre-commit run --all-filesat the end.our users.
READMEfiles and our wiki for any big design decisions, if relevant.