Tackle dask issues #518
Merged
Tackle dask issues #518
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gabegma
commented
Mar 26, 2023
gabegma
commented
Mar 26, 2023
| @@ -111,12 +111,13 @@ def start_task_on_dataset_split( | |||
| deps = [d.done_event for d in dependencies] if dependencies is not None else [] | |||
| if not all(deps): | |||
| raise ValueError("Can't wait for an unstarted Module.") | |||
| self.done_event = Event(name="-".join(map(str, self.task_id)), client=client) | |||
| self.done_event = Event(name=self.task_id, client=client) | |||
There was a problem hiding this comment.
For some reason, here it was a "-" and not a "_". Not sure why and if it was causing any issues.
gabegma
commented
Mar 26, 2023
gabegma
commented
Mar 26, 2023
|
@JosephMarinier @Dref360 I was unsuccessful at solving the issue. Still, LMK what you think of this PR. I think we should at least merge the Dask Dashboard support, and the |
gabegma
force-pushed
the
ggm/reduce-dask-issues
branch
from
586f0dc
to
7a7be05
Compare
JosephMarinier
approved these changes
Mar 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
We are now often seeing
distributed.comm.core.CommClosedError: in <TCP (closed) ConnectionPool.broadcast local=tcp://127.0.0.1:62774 remote=tcp://127.0.0.1:62755>: Stream is closederrors in the logs, which causes tasks to be lost. They are often trigger whenself.client.run(ArtifactManager.clear_cache)is called.dask/distributed; however, I can't get the router tests to work with it.Checklist:
You should check all boxes before the PR is ready. If a box does not apply, check it to acknowledge it.
ran
pre-commit run --all-filesat the end.our users.
READMEfiles and our wiki for any big design decisions, if relevant.