Show error messages from backend on API failure #524
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
I think this makes sense although I am still unsure of the design for this. The toasts generated by this are not easy to read.
Also we need to decide what to do with the general messages such as the one found here:
https://github.com/ServiceNow/azimuth/pull/524/files#diff-eab2d4424b736fc0a65af85697bd0abf297013425f52e684f71463ddcf22e16dL60
nandhinibsn
force-pushed
the
nandhini-display-back-end-error-messages
branch
from
b13a570
to
3fdf3a0
Compare
JosephMarinier
force-pushed
the
nandhini-display-back-end-error-messages
branch
from
591532d
to
c3aa758
Compare
nandhinibsn
force-pushed
the
nandhini-display-back-end-error-messages
branch
from
06c6bc2
to
672873f
Compare
| @@ -139,7 +139,7 @@ describe("PerturbationTestingPreview with Failure response", () => { | |||
| // expected error message | |||
| expect( | |||
| screen.getByText( | |||
| "Something went wrong fetching behavioral testing summary" | |||
| /Something went wrong fetching behavioral testing summary/i | |||
There was a problem hiding this comment.
Any reason for making the regexps case insensitive (i)? If not, I suggest removing it
Suggested change
| /Something went wrong fetching behavioral testing summary/i | |
| /Something went wrong fetching behavioral testing summary/ |
There was a problem hiding this comment.
Okay, tests were failing so I added regex but i is not required here. Thank you for removing it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolve #
Description:
Checklist:
You should check all boxes before the PR is ready. If a box does not apply, check it to acknowledge it.
ran
pre-commit run --all-filesat the end.our users.
READMEfiles and our wiki for any big design decisions, if relevant.