Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Validate behavioral testing number fields #537

Merged
merged 3 commits into from
Apr 11, 2023
Merged

Validate behavioral testing number fields #537

merged 3 commits into from
Apr 11, 2023

Conversation

JosephMarinier
Copy link
Contributor

@JosephMarinier JosephMarinier commented Apr 11, 2023 •
edited
Loading

Description:

I apparently missed those when doing #474.

image

Checklist:

You should check all boxes before the PR is ready. If a box does not apply, check it to acknowledge it.

  • ISSUE NUMBER. You linked the issue number (Ex: Resolve #XXX).
  • PRE-COMMIT. You ran pre-commit on all commits, or else, you
    ran pre-commit run --all-files at the end.
  • USER CHANGES. The changes are added to CHANGELOG.md and the documentation, if they impact
    our users.
  • DEV CHANGES.
    • Update the documentation if this PR changes how to develop/launch on the app.
    • Update the README files and our wiki for any big design decisions, if relevant.
    • Add unit tests, docstrings, typing and comments for complex sections.

@JosephMarinier JosephMarinier self-assigned this Apr 11, 2023
JosephMarinier
JosephMarinier commented Apr 11, 2023
View reviewed changes
azimuth/config.py Outdated Show resolved Hide resolved
@JosephMarinier JosephMarinier changed the title Validate positive integers Validate behavioral testing number fields Apr 11, 2023
gabegma
gabegma approved these changes Apr 11, 2023
View reviewed changes
Copy link
Contributor

@gabegma gabegma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!! I think you didn't do it at the time because the front-end wasn't showing yet the details of behavioral testing.

@JosephMarinier
Copy link
Contributor Author

LGTM!! I think you didn't do it at the time because the front-end wasn't showing yet the details of behavioral testing.

Ah-ha! That sounds like a good excuse! I'll take it. 🤣 Thanks!

@JosephMarinier JosephMarinier enabled auto-merge (squash) April 11, 2023 18:31
@JosephMarinier JosephMarinier force-pushed the joseph/validate-positive-integers branch from c554ce4 to cd3b82e Compare April 11, 2023 19:25
@JosephMarinier JosephMarinier merged commit f54c511 into main Apr 11, 2023
@JosephMarinier JosephMarinier deleted the joseph/validate-positive-integers branch April 11, 2023 19:53
gabegma pushed a commit that referenced this pull request Apr 19, 2023
@JosephMarinier @gabegma
Validate behavioral testing number fields (#537)
fa22cb7 
* Validate positive integers

* Change comment into field description

* Change thresholds to percentages
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gabegma gabegma gabegma approved these changes

@nandhinibsn nandhinibsn Awaiting requested review from nandhinibsn

Assignees

@JosephMarinier JosephMarinier

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@JosephMarinier @gabegma