Cleanup tasks in memory #543
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gabegma
force-pushed
the
ggm/clean-task-in-memory
branch
from
fb54a94
to
3bab4d2
Compare
JosephMarinier
approved these changes
Apr 13, 2023
| @@ -217,6 +217,10 @@ def on_end(self, fut, module): | |||
| self._store_data_in_cache(fut.result(), fut.indices) | |||
| log.info(f"{self.name} completed and stored in cache", status=fut.status) | |||
|
|
|||
| def delete_future(self): | |||
There was a problem hiding this comment.
The only question I have is whether the caller (from outside dask_module.py) needs to know HOW this works (setting future to None), or if it would be more user-friendly to simply say WHAT it does (not mentioning that it involves some future poutine), for example
Suggested change
| def delete_future(self): | |
| def clear(self): |
There was a problem hiding this comment.
I would be ok with it! I'll make the change.
There was a problem hiding this comment.
Cool! THat way, we keep the implementation for, well, the implementation. 👍
gabegma
force-pushed
the
ggm/clean-task-in-memory
branch
from
7e1ed07
to
2bd25d7
Compare
gabegma
added a commit
that referenced
this pull request
Apr 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Checklist:
You should check all boxes before the PR is ready. If a box does not apply, check it to acknowledge it.
ran
pre-commit run --all-filesat the end.our users.
READMEfiles and our wiki for any big design decisions, if relevant.