Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add options for non-normalized confusion matrix #65

Merged
merged 4 commits into from
May 10, 2022

Conversation

Dref360
Copy link
Contributor

@Dref360 Dref360 commented May 9, 2022

Description:

Add options for non-normalized confusion matrix

Checklist:

You should check all boxes before the PR is ready. If a box does not apply, check it to acknowledge
it.

  • PRE-COMMIT. You ran pre-commit on all commits, or else, you
    ran pre-commit run --all-files at the end.
  • FRONTEND TYPES. Regenerate the front-ent types if you played with types and routes.
    Run cd webapp && yarn types while the back-end is running.
  • USER CHANGES. The changes are added to CHANGELOG.md and the documentation, if they impact
    our users.
  • DEV CHANGES.
    • Update the documentation if this PR changes how to develop/launch on the app.
    • Update the README files and our wiki for any big design decisions, if relevant.
    • Add unit tests, docstrings, typing and comments for complex sections.

@Dref360 Dref360 requested a review from gabegma May 9, 2022 20:46
Copy link
Contributor

@gabegma gabegma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Tiny comment about naming.

@@ -97,3 +97,4 @@ class ModuleOptions(AliasModel):
20,
title="Nb of bins to compute for different modules.",
)
normalized: bool = Field(True, title="Normalize the confusion matrix.")
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I find it odd that confusion matrix is not mentioned in the option name. Did you have in mind that it could be useful for other modules?

Copy link
Contributor Author

@Dref360 Dref360 May 10, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

like cf_normalized?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sold! FYI - I don't mind for the route that it's called only normalized - it's only in module options where it is mixed with everything else that I find it confusing.

@Dref360 Dref360 enabled auto-merge (squash) May 10, 2022 15:07
@Dref360 Dref360 merged commit 9fd0eae into dev May 10, 2022
@Dref360 Dref360 deleted the features/cf_normalization branch May 10, 2022 15:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants