Add AaveFLIStrategyExtension #70
Conversation
There was a problem hiding this comment.
Diff between existing FlexibleLeverageStrategyExtension and AaveFLIStrategyExtension: https://gist.github.com/Alpha-Guy/1f9463f4c729e2467b98086c2b1eb001
I see that the diff is mainly due to changes in the calculation of position units and their decimal places. Would be great if you can explain the changes in the PR description or within the contract as comments.
There was a problem hiding this comment.
Diff is here
I think we should adjust the base units in the _calculateChunkRebalanceNotional function, so we dont have to add .div(10 ** (18 - strategy.xxx) to every calculate units function
|
|
||
| /** | ||
| * Derive the min repay units from collateral units for delever. Units are calculated as target collateral rebalance units multiplied by slippage tolerance | ||
| * and pair price (collateral oracle price / borrow oracle price). Output is measured to 18 decimals. |
There was a problem hiding this comment.
This is confusing if output is 18 decimals, while units in other contracts all account for decimals
|
Closing in favor of #72 |
No description provided.