Skip to content

Conversation

FlattestWhite
Copy link
Contributor

No description provided.

Copy link
Contributor

@0xModene 0xModene left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

small change needed but mostly looks good

@FlattestWhite
Copy link
Contributor Author

Just a note on this PR - circle ci atm isn't actually verifying this repo because the yarn.lock wasn't regenerated when porting it over. We cache based on the yarn.lock file. Since the yarn.lock file remains the same, the old build and test steps still pass but its pointing to ~/index-coop-private

@0xModene
Copy link
Contributor

0xModene commented Feb 7, 2022

@FlattestWhite Can you run yarn locally and resolve this?

@FlattestWhite
Copy link
Contributor Author

@FlattestWhite Can you run yarn locally and resolve this?

done

@0xModene 0xModene merged commit c4730ee into master Feb 8, 2022
@0xModene 0xModene deleted the richard-auto-publish-artifacts-npm branch February 8, 2022 20:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants