Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: IOS - ability to input sound volume #172

Merged
merged 4 commits into from
Mar 5, 2024
Merged

Conversation

trowaflo
Copy link
Contributor

Hi,

I want to be able to manage the sound volume of critical notifications on iOS.
I want to be able to select the 'none' sound option and really have no sound, cause now none is like default.

Examples:
Have no sound, but still receive critical alerts, in silent mode.
Set the sound to 25% (because 100% in a silent context is quite annoying).

Please excuse in advance if the solutions I propose do not consider Android compatibility as I do not have any devices on which to test.

Move from interruption-level to sound expand way.
Expand sound attributes like mentionned in companion doc: https://companion.home-assistant.io/docs/notifications/critical-notification

fix the 'none' sound option to respect the behavior of that 'none' sound and putting the critical sound to 0 when selected
@SgtBatten
Copy link
Owner

Pretty good. Thank you.

I don't believe this would introduce any issues for android.

I don't want to add anything directly to stable. Please add the necessary changes to the beta instead after considering my comments above.

@trowaflo
Copy link
Contributor Author

Thank to you for your reviews. I will move to beta once all issues have been resolved.

@SgtBatten
Copy link
Owner

Looks good for transposing into the beta. Thanks

@trowaflo
Copy link
Contributor Author

Transpose to beta is done.

For my information, what is the lifecycle time for the Beta? And just to understand, why use Beta instead of a development or feature branch? It seems easier to track all features that way.

@SgtBatten
Copy link
Owner

Okay i think this is good to go, the only thing is this pull request still has the stable branch changes.

If you can copy the raw github file without using your text editor and paste it into a new clean pull request I'll merge it.

feat: IOS - ability to input sound volume

Move from interruption-level to sound expand way.
Expand sound attributes like mentionned in companion doc: https://companion.home-assistant.io/docs/notifications/critical-notification

fix the 'none' sound option to respect the behavior of that 'none' sound and putting the critical sound to 0 when selected
@trowaflo
Copy link
Contributor Author

trowaflo commented Mar 4, 2024

It's strange, I rolled back the stable file.
I also disabled whitespace trimming and update beta file.
For me, the file change view is okay. Is it okay for you too?

@SgtBatten SgtBatten merged commit ad46db5 into SgtBatten:main Mar 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants