opponentplay #3549

lemz1 · 2022-01-14T13:26:40Z

Good afternoon,
I need to repost this pull request (#2770), since I was kinda stupid, but it isn't just a repost.
I updated it to the new code and changed some stuff to have less variables and less lines.

What does this do

This adds the gameplay option 'opponentplay'. If turned on lets you play the opponent chart.
It isn't a big feature but yeah.

tposejank · 2022-01-14T14:41:20Z

sick

HiroMizuki · 2022-01-14T18:44:24Z

sick

CrusherNotDrip · 2022-01-14T18:46:01Z

sick

MayoALT · 2022-01-14T19:34:24Z

sick

SrtHero278 · 2022-01-14T22:35:04Z

sick

MeguminBOT · 2022-01-15T15:23:41Z

sick

MasterDirector99 · 2022-01-16T08:23:09Z

sick

JorgeMiguel22 · 2022-01-16T22:56:05Z

why it doesnt appear anything about opponent play?

HiroMizuki · 2022-01-16T22:57:28Z

why it doesnt appear anything about opponent play?

what

JorgeMiguel22 · 2022-01-16T23:42:27Z

i searched in the options and didnt find the opponent play option

HiroMizuki · 2022-01-16T23:55:28Z

i searched in the options and didnt find the opponent play option

are u sure that u coded everything changed at the PR?
or are u sure that u compiled the right source?

JorgeMiguel22 · 2022-01-17T00:30:21Z

yeah i changed all the files needed

SrtHero278 · 2022-01-17T01:05:13Z

If you're looking through the settings through the main menu. That's not how you find it. You gotta select a song and press control.

JorgeMiguel22 · 2022-01-17T12:21:43Z

oh it worked, thx for helping

Megalonumber0ne · 2022-01-18T10:30:32Z

I coded everything in correctly but when i went to play a song (I'll use Dadbattle for an example), all of the notes appear on the opponent's side, including BF's, also when BF and DD sync both of the notes appear at the same time and can only be pressed by either the AI or you (It's mostly the AI that gets the notes)

EDIT: I have a screenshot of the notes mixing

lemz1 · 2022-01-18T13:02:33Z

I coded everything in correctly but when i went to play a song (I'll use Dadbattle for an example), all of the notes appear on the opponent's side, including BF's, also when BF and DD sync both of the notes appear at the same time and can only be pressed by either the AI or you (It's mostly the AI that gets the notes)

EDIT: I have a screenshot of the notes mixing

The note generation is somewhere in line 1870.
Are you sure that you put in

if (songNotes[1] <= 3 && opponentChart)
{
	gottaHitNote = !section.mustHitSection;
}

Maybe you did a wrong symbol instead of <=

Megalonumber0ne · 2022-01-18T14:25:18Z

Even after checking all of the code that was given to me and re-building the game i still got the same result

crowplexus · 2022-01-18T15:16:58Z

nice! merged this into my fork and it works perfectly, I've seen some bugs of course (some of which I managed to fix) but here are all of the bugs I could find

since Dad is now BF when Opponent Mode is on, Lua Scripts are completely swapped and can present issues (such as animations not working properly if lua scripts are present, or noteskins being swapped, etc)
Opponent Mode Dad can't hold notes, his animation stops looping like it should if he was actually Player 2 if you try to do so, and it loops BF's animation instead
GF Notes make it so Dad and GF sing together
Solution: on line 4013, add "&& !gfNote" in "if(opponentChart) {"
Alt Anims and Hey Notes are completely bugged, or straight up don't work sometimes (try playing Cocoa or Eggnog)
sometimes (rarely) the charts don't swap, nothing major
Miss Animations won't play if Ghost Tapping is disabled for Player 2 (try any Week 3 song with Ghost Tapping off)

that everything I know!

lemz1 · 2022-01-18T17:26:31Z

Miss Animations won't play if Ghost Tapping is disabled for Player 2 (try any Week 3 song with Ghost Tapping off)
Alt Anims and Hey Notes are completely bugged, or straight up don't work sometimes (try playing Cocoa or Eggnog)
GF Notes make it so Dad and GF sing together

fixed and commited

Opponent Mode Dad can't hold notes, his animation stops looping like it should if he was actually Player 2 if you try to do so, and it loops BF's animation instead

can't get it to work bruh

since Dad is now BF when Opponent Mode is on, Lua Scripts are completely swapped and can present issues (such as animations not working properly if lua scripts are present, or noteskins being swapped, etc)

Dad isn't really BF. When BF hits a note Dad plays the animations. So that wouldn't be a problem.
Tho noteskins would probably be a problem

XtraXD1 · 2022-01-18T18:27:15Z

sick

crowplexus · 2022-01-18T21:31:17Z

(latest update)

2022-01-18.17-27-08.mp4

2022-01-18.17-30-26.mp4

the same doesn't happen for BF

lemz1 · 2022-01-19T16:25:14Z

(latest update)
2022-01-18.17-27-08.mp4
2022-01-18.17-30-26.mp4

the same doesn't happen for BF

Are you sure you coded everything right. The thing with bf dying doesn't really make sense, since I didn't change how health works. Also I noticed that you are using "Bedrock Engine". There's probably different code

crowplexus · 2022-01-19T16:39:31Z

(latest update)
2022-01-18.17-27-08.mp4
2022-01-18.17-30-26.mp4
the same doesn't happen for BF

Are you sure you coded everything right. The thing with bf dying doesn't really make sense, since I didn't change how health works. Also I noticed that you are using "Bedrock Engine". There's probably different code

the latest commit fixed it

Stilic · 2022-01-21T11:48:11Z

Also I noticed that you are using "Bedrock Engine".

It is his own fork of Pysch Engine with custom features from different PRs.

crowplexus · 2022-01-21T14:24:12Z

BE doesn't change the code as much, it's just that I probably didn't merge the changes correctly, yet it worked with the latest commit fine

crowplexus · 2022-02-24T17:47:27Z

there's a glitch with the Cam Zoom event, but I found the solution pretty quickly

also when you go back to the titlescreen

why do I not pay more attention. Fixing the crash resulted in botplay animation lasting forever

FletchunterMC108338 · 2022-02-25T22:10:55Z

Nice but the only problem is lua swapped when opponentplay.

You can now use notehitfix and normal notehit while using multiple scripts. Example Whitty Definitive Edition: the accuracy function is just goodNoteHit since it is only supposed to happen when you hit it. ballistic shake when whitty sings uses opponentNoteHitFix

FletchunterMC108338 · 2022-02-25T22:55:00Z

Ok

crowplexus · 2022-03-01T19:48:28Z

source/GameplayChangersSubstate.hx

@@ -91,7 +91,7 @@ class GameplayChangersSubstate extends MusicBeatSubstate
 		var option:GameplayOption = new GameplayOption('Botplay', 'botplay', 'bool', false);
 		optionsArray.push(option);

-		var option:GameplayOption = new GameplayOption('Play Opponents Chart', 'opponentplay', 'bool', false);
+		var option:GameplayOption = new GameplayOption("Play Opponent's Chart", 'opponentplay', 'bool', false);


I think a better name for this could be "Play as Opponent"

shish kebab

frantastic24 · 2022-03-03T03:31:45Z

this seems to break gf characters singing when the option is on, they don't return to their idle

Friday.Night.Funkin._.Psych.Engine.2022-03-03.00-17-13.mp4

you won't be able to make gf to the sing anim forever but this will be less code so I think that this is for the better

crowplexus · 2022-07-04T15:47:57Z

oh yeah since this is closed and finished now and won't be merged, I recommend to everyone who wants this feature to simply merge them to your own forks or private builds

…tory mode and press CTRL Key.) From ShadowMario/FNF-PsychEngine#3549

NOW FULLY FUNCTIONABLE!! I also added support for when the opponent presses a key and holds there until the key is released 😈 Code source from pull request in the Psych Engine Repo: ShadowMario#3549 Big props to Josephjr05 (https://github.com/Josephjr05) For launching a commit of the fixed version of opponent play

opponentplay

abf38fe

lemz1 mentioned this pull request Jan 14, 2022

Play Opponent's Chart Option #2770

Closed

frantastic24 mentioned this pull request Jan 18, 2022

Left Side #3716

Closed

Update PlayState.hx

e6b95ac

bruh

3c258e8

lemz1 added 2 commits February 8, 2022 15:11

should be fixed now

5f98fd0

Merge branch 'ShadowMario:main' into opponentplay

768f95a

JorosTheModderPH approved these changes Feb 20, 2022

View reviewed changes

lemz1 added 2 commits February 21, 2022 18:59

crash doesn't happen anymore when opening 'adjust delay and combo'

ee308cd

now please be actually fixed

a32a2ef

lemz1 added 5 commits February 24, 2022 18:59

fix for Cam Zoom Event by Gui-iago

bfc9c16

opponentplay is false on game start

4c24308

also when you go back to the titlescreen

botPlay anims work

0482aa0

why do I not pay more attention. Fixing the crash resulted in botplay animation lasting forever

IQ below average

7529ce0

longer bf animation when in opponentplay

8e437e5

FletchunterMC108338 approved these changes Feb 25, 2022

View reviewed changes

improved notehitFix

bb172f2

You can now use notehitfix and normal notehit while using multiple scripts. Example Whitty Definitive Edition: the accuracy function is just goodNoteHit since it is only supposed to happen when you hit it. ballistic shake when whitty sings uses opponentNoteHitFix

grammar mistake, I lose

a1434fe

crowplexus reviewed Mar 1, 2022

View reviewed changes

lemz1 added 2 commits March 1, 2022 20:50

Update GameplayChangersSubstate.hx

ef351ed

animations work properly

53aba4f

lemz1 added 5 commits March 3, 2022 16:30

anims should be fixed now

6fa84b3

this is better

740496c

you won't be able to make gf to the sing anim forever but this will be less code so I think that this is for the better

Merge branch 'main' into opponentplay

eeed182

Update PlayState.hx

50f0433

Merge branch 'main' into opponentplay

d39db3c

ShadowMario closed this Jul 4, 2022

Josephjr05 added a commit to Josephjr05/The-SkyDecay-Project that referenced this pull request Dec 29, 2022

Opponent Play??? (Play as the opponent side by going to freeplay or s…

04ccaf3

…tory mode and press CTRL Key.) From ShadowMario/FNF-PsychEngine#3549

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

opponentplay #3549

opponentplay #3549

lemz1 commented Jan 14, 2022

tposejank commented Jan 14, 2022

HiroMizuki commented Jan 14, 2022

CrusherNotDrip commented Jan 14, 2022

MayoALT commented Jan 14, 2022

SrtHero278 commented Jan 14, 2022

MeguminBOT commented Jan 15, 2022

MasterDirector99 commented Jan 16, 2022

JorgeMiguel22 commented Jan 16, 2022

HiroMizuki commented Jan 16, 2022

JorgeMiguel22 commented Jan 16, 2022

HiroMizuki commented Jan 16, 2022

JorgeMiguel22 commented Jan 17, 2022

SrtHero278 commented Jan 17, 2022

JorgeMiguel22 commented Jan 17, 2022

Megalonumber0ne commented Jan 18, 2022 •

edited

Loading

lemz1 commented Jan 18, 2022

Megalonumber0ne commented Jan 18, 2022 •

edited

Loading

crowplexus commented Jan 18, 2022

lemz1 commented Jan 18, 2022 •

edited

Loading

XtraXD1 commented Jan 18, 2022

crowplexus commented Jan 18, 2022

lemz1 commented Jan 19, 2022 •

edited

Loading

crowplexus commented Jan 19, 2022

Stilic commented Jan 21, 2022

crowplexus commented Jan 21, 2022

crowplexus commented Feb 24, 2022

FletchunterMC108338 commented Feb 25, 2022

FletchunterMC108338 commented Feb 25, 2022

crowplexus Mar 1, 2022

lemz1 Mar 1, 2022

frantastic24 commented Mar 3, 2022

crowplexus commented Jul 4, 2022

opponentplay #3549

opponentplay #3549

Conversation

lemz1 commented Jan 14, 2022

What does this do

tposejank commented Jan 14, 2022

HiroMizuki commented Jan 14, 2022

CrusherNotDrip commented Jan 14, 2022

MayoALT commented Jan 14, 2022

SrtHero278 commented Jan 14, 2022

MeguminBOT commented Jan 15, 2022

MasterDirector99 commented Jan 16, 2022

JorgeMiguel22 commented Jan 16, 2022

HiroMizuki commented Jan 16, 2022

JorgeMiguel22 commented Jan 16, 2022

HiroMizuki commented Jan 16, 2022

JorgeMiguel22 commented Jan 17, 2022

SrtHero278 commented Jan 17, 2022

JorgeMiguel22 commented Jan 17, 2022

Megalonumber0ne commented Jan 18, 2022 • edited Loading

lemz1 commented Jan 18, 2022

Megalonumber0ne commented Jan 18, 2022 • edited Loading

crowplexus commented Jan 18, 2022

lemz1 commented Jan 18, 2022 • edited Loading

XtraXD1 commented Jan 18, 2022

crowplexus commented Jan 18, 2022

lemz1 commented Jan 19, 2022 • edited Loading

crowplexus commented Jan 19, 2022

Stilic commented Jan 21, 2022

crowplexus commented Jan 21, 2022

crowplexus commented Feb 24, 2022

FletchunterMC108338 commented Feb 25, 2022

FletchunterMC108338 commented Feb 25, 2022

crowplexus Mar 1, 2022

Choose a reason for hiding this comment

lemz1 Mar 1, 2022

Choose a reason for hiding this comment

frantastic24 commented Mar 3, 2022

crowplexus commented Jul 4, 2022

Megalonumber0ne commented Jan 18, 2022 •

edited

Loading

Megalonumber0ne commented Jan 18, 2022 •

edited

Loading

lemz1 commented Jan 18, 2022 •

edited

Loading

lemz1 commented Jan 19, 2022 •

edited

Loading