Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Feature Request]: enhance switch to iframe usability #902

Closed
MohabMohie opened this issue Feb 24, 2023 · 0 comments
Closed

[Feature Request]: enhance switch to iframe usability #902

MohabMohie opened this issue Feb 24, 2023 · 0 comments
Assignees
@magdyheiba
Labels
enhancement New feature or request good first issue Good for newcomers java Pull requests that update Java code

Comments

@MohabMohie
Copy link
Contributor 

//TODO: switch to iframe should be a browser action not an element action
        driver.get().browser().navigateToURL("https://github.com/ShaftHQ/SHAFT_ENGINE");
        var text = driver.get().element().switchToIframe(frame).getText(shaft_img);
@MohabMohie MohabMohie added enhancement New feature or request good first issue Good for newcomers java Pull requests that update Java code labels Feb 24, 2023
@MohabMohie MohabMohie self-assigned this Feb 24, 2023
@magdyheiba magdyheiba assigned magdyheiba and unassigned MohabMohie Apr 11, 2023
magdyheiba added a commit to magdyheiba/SHAFT_ENGINE that referenced this issue Apr 12, 2023
@magdyheiba
Enhance Feature ShaftHQ#902
2811883
MohabMohie pushed a commit that referenced this issue Apr 14, 2023
@magdyheiba
Enhance Feature #902 (#1049)
17f8274 
* Enhance Feature #902

* Adding the missing.perform()
MohabMohie added a commit that referenced this issue Apr 14, 2023
@MohabMohie @magdyheiba
revamping element actions failure reporting (#1053)
5832dfb 
* initial attempt

Signed-off-by: MohabMohie <Mohab.MohieElDeen@outlook.com>

* Enhance Feature #902 (#1049)

* Enhance Feature #902

* Adding the missing.perform()

* initial attempt

Signed-off-by: MohabMohie <Mohab.MohieElDeen@outlook.com>

* refactoring all element actions failures

- Tested MultipleElementsFailure for click and type
- Tested NoSuchElementFailure for click and type

Signed-off-by: MohabMohie <Mohab.MohieElDeen@outlook.com>

* code cleanup -> intelliJ AI

Signed-off-by: MohabMohie <Mohab.MohieElDeen@outlook.com>

* fix warnings -> intelliJ AI

Signed-off-by: MohabMohie <Mohab.MohieElDeen@outlook.com>

* removing duplicate test class due to merge

Signed-off-by: MohabMohie <Mohab.MohieElDeen@outlook.com>

* attempted fix for #1055

Signed-off-by: MohabMohie <Mohab.MohieElDeen@outlook.com>

---------

Signed-off-by: MohabMohie <Mohab.MohieElDeen@outlook.com>
Co-authored-by: Magdy Heiba <38945724+magdyheiba@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@magdyheiba magdyheiba

Labels
enhancement New feature or request good first issue Good for newcomers java Pull requests that update Java code
Projects
No open projects
SHAFT
Status: ✅ Done
Milestone
No milestone
Development

No branches or pull requests
2 participants
@MohabMohie @magdyheiba